Bug 305162

Thanks for reporting. I agree that is really nice idea and improvement, although I need to get more knowledge about the KDE notification system to judge whether it is possible to do that.

From the notification side, choqok (KDE-based, but not part of the "official" core KDE SC) does something like this, at least from the notification side.  It has a button in the notification that I can click on, and that brings choqok up to nearly (!?) the front, showing it if it was minimised, switching desktops (I think), etc.  Maybe if you looked at choqok's code for notifications it might inspire you?

Thanks a lot for the response.

Created attachment 75789 [details]
Makes a button on the notification window open the responsible session

Hi,

The patch here creates a button which opens the session which caused the bell when a notification is sent.

It involves a bit (maybe too much?) of signal slot connections, since the main window should be shown ,but the underlying session giving the bell naturally doesn't know about the application it's located in etc.

Hope this is useful

(In reply to comment #3)
> Created attachment 75789 [details]
> Makes a button on the notification window open the responsible session
> 
> Hi,
> 
> The patch here creates a button which opens the session which caused the
> bell when a notification is sent.
> 
> It involves a bit (maybe too much?) of signal slot connections, since the
> main window should be shown ,but the underlying session giving the bell
> naturally doesn't know about the application it's located in etc.
> 
> Hope this is useful

Thanks for the patch. It really helps. I will try to make the feature and patch into KDE SC 4.11

(In reply to comment #4)
> 
> Thanks for the patch. It really helps. I will try to make the feature and
> patch into KDE SC 4.11

I'm happy to hear that I can be helpful. I enjoy making these minor improvement patches and since the response from you Konsole maintainers has been so positive, I'll hopefully continue to do so.

Btw. my patch introduces a warning I forgot to fix about an unused variable in the notificationClicked() function in TerminalDisplay.cpp. Simply removing the name of the variable or using the Q_UNUSED macro gets rid of that warning.

I can resubmit the patch with that change if you wish?

Created attachment 99815 [details]
Updated patch

I updated the patch to build with the latest konsole master branch.

I don't need this myself, so if someone else wants to feel free to continue on it on reviewboard.kde.org.

So, what happened to this patch? Did it get forgotten?

I'm getting notifications saying "Bell in session 'Default'", which is pretty useless since all my tabs are using the default terminal configuration, and there's no way to find out which one is belling and no button.

Yes, I don't recall this report at all - I'll try to look at it sometime.

does systemd journal learn of BELL events ?

A few months ago I noticed that if I click on a Slack notification it not only focuses the rigth tab in my browser (Opera), it also takes me to the channel where the notificacion originated.

So, theoretically this should be possible to implement in Konsole and other apps.

In fact, I thought this may actually be working right now.

But how to test it? Is there a simple way to reproduce a bell in Konsole?

A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/581

Git commit 8fb68993891996dfcb1dee0d3ddc97870b19d430 by Tomaz  Canabrava, on behalf of Luis Javier Merino Morán.
Committed on 05/07/2022 at 09:04.
Pushed by tcanabrava into branch 'master'.

Focus session from notification

Adds a "Show session" button to notifications, which, when clicked, will
focus the originating session.

Original patch by Kasper Laudrup at bug 305162, then updated by Martin
T. H. Sandsmark.

Now updated and extended to silence/activity/process termination
notifications, adding support for focusing a TerminalDisplay inside a
hierarchy of ViewSplitters inside a TabbedViewContainer, and using
KWindowSystem::forceActiveWindow() instead of ::activateWindow().
Related: bug 344208

M  +6    -0    src/MainWindow.cpp
M  +3    -0    src/MainWindow.h
M  +1    -0    src/ViewManager.cpp
M  +2    -0    src/ViewManager.h
M  +14   -10   src/session/Session.cpp
M  +8    -5    src/session/SessionController.cpp
M  +9    -4    src/terminalDisplay/TerminalBell.cpp
M  +3    -1    src/terminalDisplay/TerminalBell.h
M  +5    -0    src/terminalDisplay/TerminalDisplay.cpp
M  +3    -0    src/terminalDisplay/TerminalDisplay.h
M  +14   -0    src/widgets/ViewContainer.cpp
M  +1    -0    src/widgets/ViewContainer.h

https://invent.kde.org/utilities/konsole/commit/8fb68993891996dfcb1dee0d3ddc97870b19d430

This is really cool!

Does anybody know if this will work for yakuake also, or only konsole?
X11, Wayland or both?

Thanks!