Summary: | selected place looks uglyand incomplete | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Tanja Schulte <nightowl> |
Component: | panels: places | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | emmanuelpescosta099 |
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/1f69714a23a222b5edabfdad9896e58a4818729e | Version Fixed In: | 4.14.0 |
Description
Tanja Schulte
2012-08-06 04:49:18 UTC
Thanks for the report! I agree that the false color looks strange, e.g., if the original color is red. Resetting assignee to default as per bug #305719 review-request: https://git.reviewboard.kde.org/r/106827/ Git commit 1f69714a23a222b5edabfdad9896e58a4818729e by Frank Reininghaus. Committed on 03/07/2014 at 22:49. Pushed by freininghaus into branch 'master'. Improve drawing selected items in Compact/Details View and Places Panel This commit removes the icon tinting for the selected item in Compact and Details View, and extends the selection rectangle such that it includes the icon area as well. The icon tinting can be disturbing, and having a selection rectangle that only includes the text can look a bit strange, especially in the Places Panel. REVIEW: 119018 FIXED-IN: 4.14.0 M +1 -1 dolphin/src/kitemviews/kitemlistwidget.cpp M +5 -0 dolphin/src/kitemviews/kitemlistwidget.h M +24 -1 dolphin/src/kitemviews/kstandarditemlistwidget.cpp M +1 -0 dolphin/src/kitemviews/kstandarditemlistwidget.h http://commits.kde.org/kde-baseapps/1f69714a23a222b5edabfdad9896e58a4818729e Note that the icons and previews of selected files in Icons View are still tinted (bug 309722). Unfortunately, removing the tinting in Icons View might lead to some problems, which should be resolved first. See bug 309722 or https://git.reviewboard.kde.org/r/119018/ for a summary of these problems. |