Bug 304643 - selected place looks uglyand incomplete
Summary: selected place looks uglyand incomplete
Alias: None
Product: dolphin
Classification: Applications
Component: panels: places (show other bugs)
Version: 2.1
Platform: Ubuntu Linux
: NOR wishlist with 1 vote (vote)
Target Milestone: ---
Assignee: Dolphin Bug Assignee
Depends on:
Reported: 2012-08-06 04:49 UTC by Tanja Schulte
Modified: 2014-07-03 22:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.0


Note You need to log in before you can comment on or make changes to this bug.
Description Tanja Schulte 2012-08-06 04:49:18 UTC
Since KDE SSC 4.9 the selected place in the sidebar looks ugly. Before it had a nice full slightly rounded elegant badge around the text and the icon and the icon was in its native color, but now only the text has a colored background, direct beginning at the first letter of the word therefore text looks ugly squeezed to the left. The icon itself is shown in a false color. I reluctantly accept the false color in the file window for selected files (does not look good either and I'd wish to have the icon in real color with just colored background back) because there it is a temporary look  but in the sidebar I see i all the time and it does not look smooth but somehow wrong... To show icon (true color) and text connected with unitary background looks better and is easier to see/grab/understand/overlook.

Reproducible: Always
Comment 1 Frank Reininghaus 2012-08-06 08:58:21 UTC
Thanks for the report! I agree that the false color looks strange, e.g., if the original color is red.
Comment 2 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:21:33 UTC
Resetting assignee to default as per bug #305719
Comment 3 Emmanuel Pescosta 2012-10-25 12:45:39 UTC
review-request: https://git.reviewboard.kde.org/r/106827/
Comment 4 Frank Reininghaus 2014-07-03 22:53:54 UTC
Git commit 1f69714a23a222b5edabfdad9896e58a4818729e by Frank Reininghaus.
Committed on 03/07/2014 at 22:49.
Pushed by freininghaus into branch 'master'.

Improve drawing selected items in Compact/Details View and Places Panel

This commit removes the icon tinting for the selected item in Compact
and Details View, and extends the selection rectangle such that it
includes the icon area as well. The icon tinting can be disturbing, and
having a selection rectangle that only includes the text can look a bit
strange, especially in the Places Panel.
REVIEW: 119018
FIXED-IN: 4.14.0

M  +1    -1    dolphin/src/kitemviews/kitemlistwidget.cpp
M  +5    -0    dolphin/src/kitemviews/kitemlistwidget.h
M  +24   -1    dolphin/src/kitemviews/kstandarditemlistwidget.cpp
M  +1    -0    dolphin/src/kitemviews/kstandarditemlistwidget.h

Comment 5 Frank Reininghaus 2014-07-03 22:56:48 UTC
Note that the icons and previews of selected files in Icons View are still tinted (bug 309722). Unfortunately, removing the tinting in Icons View might lead to some problems, which should be resolved first. See bug 309722 or https://git.reviewboard.kde.org/r/119018/ for a summary of these problems.