| Summary: | Add a context action to open an URL in the current tab | ||
|---|---|---|---|
| Product: | [Unmaintained] rekonq | Reporter: | Adrián Chaves (Gallaecio) <adrian> |
| Component: | general | Assignee: | Andrea Diamantini <adjam7> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | wrathful.mite |
| Priority: | NOR | ||
| Version: | latest git snapshot | ||
| Target Milestone: | 2.0 | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/rekonq/c7fa562d5e2bf312700b1f02863535887f80ba48 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Patch to apply the feature. | ||
|
Description
Adrián Chaves (Gallaecio)
2012-07-22 07:20:32 UTC
Created attachment 72679 [details] Patch to apply the feature. Implementation is easy, I wrote the patch while trying to figure out where to start to solve https://bugs.kde.org/show_bug.cgi?id=237095. NOTE: This does not solve the referenced issue at all, although it is related. Sorry for missing reply. We'll see if your feature request can match 1.1 features :) Git commit 495d83777e2eaa7c7d604009cc99a446e2964f90 by Andrea Diamantini. Committed on 14/08/2012 at 16:59. Pushed by adjam into branch 'IconLink'. Guess if url is on target blank and eventually show a describing icon We show "window-new" or blank target links and "mail-message-new" on mailto ones. The same as Konqueror does :) Also, based on the hovering guess, shown different contextual menus Related: bug 237095 M +2 -0 src/CMakeLists.txt M +135 -12 src/webview.cpp M +7 -1 src/webview.h http://commits.kde.org/rekonq/495d83777e2eaa7c7d604009cc99a446e2964f90 Closed cause of the commit push. Reopening... *** Bug 237095 has been marked as a duplicate of this bug. *** This feature is not available in Rekonq 2.0 (tested from http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_a_target), didn’t the commit fixed it? 1.x and 2.0 diverged at same point. It needs to be "backported". Git commit c7fa562d5e2bf312700b1f02863535887f80ba48 by Andrea Diamantini. Committed on 11/03/2013 at 18:59. Pushed by adjam into branch 'master'. Guess if url is on target blank and show different contextual actions I would not re-enable the "describing" icon part because it is NOT really working here. I'm having troubles when I show the icon and switch pages. Hope this is enough Related: bug 237095 M +69 -9 src/webtab/webview.cpp M +4 -0 src/webtab/webview.h http://commits.kde.org/rekonq/c7fa562d5e2bf312700b1f02863535887f80ba48 |