| Summary: | Desktop grid effect changes activities | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Sebastian Kuźlak <sebastiankuzlak> |
| Component: | activities | Assignee: | Vlad Zahorodnii <vlad.zahorodnii> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dnicolas, gavin.cooper, ivan.cukic, kroppy1q, migacz85, v13, vlad.zahorodnii |
| Priority: | NOR | ||
| Version: | 4.8.80 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| URL: | http://youtu.be/WisvuJ2Ts_w | ||
| Latest Commit: | https://commits.kde.org/kwin/e918cb5d2d3de033635d0cd7463de25fd6312b24 | Version Fixed In: | 5.13.4 |
| Sentry Crash Report: | |||
|
Description
Sebastian Kuźlak
2012-06-08 14:02:10 UTC
could be related to bug #301239 - at least i can't reproduce it atm. Im sorry it looks like it might be my mistake. Ive deleted ~/.kde4 dir and i cannot reproduce it any more. Sorry for the confusion. I experience exactly this bug and have been able to reproduce it every time since version 4.8 on Debian. It's the same with version 4.9.2 on Arch. The reason it sometimes can't be reproduced is because Desktop Grid has an option called "Use Present Windows effect to layout the windows" which obscures this bug and is also the default. You can see that this option is disabled in Thomas's video that he linked. When he started with a fresh ~/.kde4 directory, he probably kept the default. I believe the solution will look similar to bug #242555 and this commit: http://commits.kde.org/kde-workspace/e9410ba51e4674819fc8c37c8f122f1233a8c78a Another activities-related inconsistency I just discovered is related to this one. If, in Activity A, you use Desktop Grid to drag and rearrange the desktops, the same desktops are also rearranged in Activity B. This may technically be a separate bug, but it illustrates that there is a mix of Activities-aware and Activities-unaware code that limits the adoption of Activities in general. Bug reproducible. Please refile the different bug if it still exists after this one was fixed. The reason why this happens is that the activity code was stuffed onto the existing during a more or less unmentored GSoC. FYI: This is still present in 4.10.2. It's funny because you can have an empty activity, start the desktop-grid, click somewhere and you end up switching back to another activity. Takes some effort to to understand what you just happened, especially if you use the same background in the two activities. It also gets really confusing when you try to drag a whole desktop (in desktop grid mode) and you end up dragging an invisible window (from another activity) instead. Unfortunately it kind of renders the grid effect useless when you have multiple activities. Is this a fix? https://git.reviewboard.kde.org/r/110824/ If yes can you include it? this is still present in 5.5 This bug still happens in 5.10.5 and is annoying as hell. Enabling "Use present windows" seems to make it work. This bug is annoying as hell i agree ! Please fix it. Or at least tell me how i can fix it. Option "using present window" is showing windows organised in desktop. But i want to see them how they are organised by myself. As they are! And fix probably is a few line of code. Git commit 0c3047a8f1d4a70f39250c759224a7dfab72a76b by Vlad Zagorodniy. Committed on 11/07/2018 at 13:39. Pushed by vladz into branch 'Plasma/5.13'. [effects/desktopgrid] Don't change activities Summary: If the Desktop Grid effect doesn't use the Present Windows effect to layout windows, windowAt helper can return a window that doesn't belong to current activity because it doesn't check whether that window belongs to current activity. This change addresses that problem by adding corresponding check. FIXED-IN: 5.13.4 Test Plan: //Unchecked "Use Present Windows effect to layout the windows".// * Switched to activity #1 * Switched to virtual desktop #1 * Launched Konsole and maximized it(to increate hit area) * Switched to activity #2 * Switched to virtual desktop #2 * Launched Dolphin and maximized it * Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2 is still active) * Switched to activity #1 * Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1 is still active) Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14046 M +1 -1 effects/desktopgrid/desktopgrid.cpp https://commits.kde.org/kwin/0c3047a8f1d4a70f39250c759224a7dfab72a76b You found it ! That is fantastic :D After living with that bug more than a year is a great information ! :D Can you tell me how i can apply this changes ? I'm on manjaro. Thanks Vlad! Thanks Vlad, and thanks Marcin for bringing this back to life! Git commit e918cb5d2d3de033635d0cd7463de25fd6312b24 by Vlad Zagorodniy. Committed on 27/08/2019 at 05:22. Pushed by vladz into branch 'Plasma/5.12'. [effects/desktopgrid] Don't change activities Summary: If the Desktop Grid effect doesn't use the Present Windows effect to layout windows, windowAt helper can return a window that doesn't belong to current activity because it doesn't check whether that window belongs to current activity. This change addresses that problem by adding corresponding check. FIXED-IN: 5.13.4 Test Plan: //Unchecked "Use Present Windows effect to layout the windows".// * Switched to activity #1 * Switched to virtual desktop #1 * Launched Konsole and maximized it(to increate hit area) * Switched to activity #2 * Switched to virtual desktop #2 * Launched Dolphin and maximized it * Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2 is still active) * Switched to activity #1 * Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1 is still active) Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14046 M +1 -1 effects/desktopgrid/desktopgrid.cpp https://commits.kde.org/kwin/e918cb5d2d3de033635d0cd7463de25fd6312b24 *** Bug 410899 has been marked as a duplicate of this bug. *** |