Summary: | Now Playing widget: Stop button should give visual response | ||
---|---|---|---|
Product: | [Plasma] plasma4 | Reporter: | Janek Bevendorff <kde> |
Component: | widget-nowplaying | Assignee: | Alex Merry <alex.merry> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alex.merry |
Priority: | NOR | ||
Version: | 4.8.80 (beta1) | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-workspace/1fdca98b83c465bf0cd63974553a8365fa7f67a9 | Version Fixed In: | 4.9 |
Description
Janek Bevendorff
2012-06-08 08:37:26 UTC
Git commit 1fdca98b83c465bf0cd63974553a8365fa7f67a9 by Alex Merry. Committed on 11/06/2012 at 12:40. Pushed by alexmerry into branch 'master'. mpris2-dataengine: fake a CanStop capability This allows the stop button to be greyed out when there is nothing to be stopped, making the user experience slightly less confusing. M +10 -0 plasma/generic/dataengines/mpris2/playercontainer.cpp M +4 -1 plasma/generic/dataengines/mpris2/playercontainer.h M +1 -1 plasma/generic/dataengines/mpris2/playercontrol.cpp http://commits.kde.org/kde-workspace/1fdca98b83c465bf0cd63974553a8365fa7f67a9 I've changed it so the widget will grey out the Stop button when the media player reports it is stopped. Currently, Amaork reports it is still playing during fade-out, although it removes the track metadata, so it is clear _something_ has happened, as all the track information disappears (this is with Amarok from git master). Given that pressing stop again _is_ a sensible option (to cancel the fade-out), I think this is the best compromise. This should be fixed in 4.9 RC1. |