Summary: | phonon-gstreamer doesnt display stream meta-data correctly in amarok. | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | cherub.rockin |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a9016009, elbin.p, martin.sandsmark, matej, myriam, romain.perier, tdfischer, znurree |
Priority: | NOR | ||
Version: | 2.5-git | ||
Target Milestone: | 2.7 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
See Also: | https://bugzilla.gnome.org/show_bug.cgi?id=676215 | ||
Latest Commit: | http://commits.kde.org/amarok/8d623b9329068d95de8d235f5c543f165976af26 | Version Fixed In: | 2.7 |
Sentry Crash Report: |
Description
cherub.rockin
2012-05-17 10:15:58 UTC
If this is not an issue in Phonon / Amarok but gstreamer please move results to https://bugzilla.gnome.org/show_bug.cgi?id=676215 . Thanks! It isnt Gstreamer, if you do realise, that is my bug i reporteded to gnome (mistakenly) *** Bug 300334 has been marked as a duplicate of this bug. *** This is IMO a bug in Amarok, I've got a patch pending, moment. This bug is solved for me with latest Phonon-GStreamer (4.6.1). cherub.rockin: Can you confirm znurree's comment that this is fixed in Phonon-GStreamer 4.6.1? Git commit 8d623b9329068d95de8d235f5c543f165976af26 by Matěj Laitl. Committed on 24/07/2012 at 11:51. Pushed by laitl into branch 'master'. MultiTrack, EngineController: Fix MultiTrack API In previous API, the only way to get next track url is multiTrack->next(), which also advances the current index. EngineController doesn't work this way, it needs to know next url in the slotAboutToFinish(), but only should only advance the index in slotNewTrackPlaying() (because aboutToFinish() may be even emitted multiple times etc). Correct the api so that the only non-const method is setSource( int index ). Also change m_multiSource handling in EngineController so that it is created and destroyed in slotNewTrackPlaying(), which is a correct place to do that. Also contains clean-ups to the MultiTrack classes. This change fixes a bug for MultiTrack streams where metadata wouldn't be updated because EngineController thinks different source is playing. Therefore I think it fixes bug 300189. Reporters, please reopen the bug if this patch doesn't fix the bug and provide full `amarok --debug` output in that case. FIXED-IN: 2.7 M +18 -15 src/EngineController.cpp M +1 -1 src/EngineController.h M +25 -7 src/core-impl/capabilities/multisource/MultiSourceCapabilityImpl.cpp M +17 -23 src/core-impl/capabilities/multisource/MultiSourceCapabilityImpl.h M +34 -54 src/core-impl/meta/multi/MultiTrack.cpp M +65 -69 src/core-impl/meta/multi/MultiTrack.h M +3 -8 src/core/capabilities/MultiSourceCapability.cpp M +40 -22 src/core/capabilities/MultiSourceCapability.h M +28 -34 tests/core-impl/meta/multi/TestMetaMultiTrack.cpp M +5 -5 tests/core-impl/meta/multi/TestMetaMultiTrack.h http://commits.kde.org/amarok/8d623b9329068d95de8d235f5c543f165976af26 |