Summary: | Hover-feedback for "+" sign to select files is missing | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Christoph Feck <cfeck> |
Component: | view-engine: icons mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | emmanuelpescosta099, noacco, richard.llom, wbauer1 |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/34a7860714ad6cd1df088536b25d0fd492cc9b38 | Version Fixed In: | 4.13.2 |
Description
Christoph Feck
2012-05-03 20:54:32 UTC
I agree, this should be improved and it is OK marking this as bug. I'm not sure whether I can implement this until 4.9.0, but this kind of things can also be done for 4.9.x... Resetting assignee to default as per bug #305719 *** Bug 311598 has been marked as a duplicate of this bug. *** *** Bug 311598 has been marked as a duplicate of this bug. *** *** Bug 318748 has been marked as a duplicate of this bug. *** The interesting thing is that there is some code to handle this - see the members updatePixmap(), hoverEnterEvent(QGraphicsSceneHoverEvent*), and hoverLeaveEvent(QGraphicsSceneHoverEvent*) of KItemListSelectionToggle. However, it does not work. One problem is that updatePixmap() does the following: if (m_hovered) { KIconLoader::global()->iconEffect()->apply(m_pixmap, KIconLoader::Desktop, KIconLoader::ActiveState); } But the "apply(...)" call does not modify m_pixmap at all, but it returns a new QPixmap which has the effect applied. But even prepending the command with "m_pixmap = " does not help - it seems that the hover*Event() functions of KItemListSelectionToggle are never called. Unfortunately, I don't quite understand why :-( Review-Request: https://git.reviewboard.kde.org/r/116028/ Git commit 24326d447358f0dbfc18963743207d4a3d4f1c9e by Emmanuel Pescosta. Committed on 03/03/2014 at 21:06. Pushed by emmanuelp into branch 'KDE/4.13'. Add a hover effect for the selection toggle. FIXED-IN: 4.13.0 REVIEW: 116028 M +5 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +7 -0 dolphin/src/kitemviews/kitemlistwidget.cpp M +2 -0 dolphin/src/kitemviews/kitemlistwidget.h M +12 -21 dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp M +2 -2 dolphin/src/kitemviews/private/kitemlistselectiontoggle.h http://commits.kde.org/kde-baseapps/24326d447358f0dbfc18963743207d4a3d4f1c9e Hello Emmanuel, how exactly is your patch supposed to work? I noticed +/- signs are now in grey when hovering over the file/folder icon, however there is no additional effect (they stay grey) when hovering over the +/- sign. (?) (In reply to comment #9) > I noticed +/- signs are now in grey when hovering over the file/folder icon, > however there is no additional effect (they stay grey) when hovering over > the +/- sign. (?) I can confirm this here (openSUSE 13.1, KDE SC 4.13.0). The +/- signs are now in disabled state always, there's still no feedback when you hover over them. I'm reopening this bug report therefore. Oh sorry, something went wrong before I have pushed the patch! Thanks for reopening this report! It should be "selectionToggleRect().contains(pos)" instead of "m_selectionToggle->contains(pos)" in KItemListWidget::setHoverPosition(const QPointF& pos). Git commit 34a7860714ad6cd1df088536b25d0fd492cc9b38 by Emmanuel Pescosta. Committed on 25/05/2014 at 16:55. Pushed by emmanuelp into branch 'KDE/4.13'. Use "selectionToggleRect().contains(pos)" instead of "m_selectionToggle->contains(pos)" in KItemListWidget::setHoverPosition(const QPointF& pos). This wrong check was accidentally introduced by commit 24326d447358f0dbfc18963743207d4a3d4f1c9e REVIEW: 118320 FIXED-IN: 4.13.2 M +1 -1 dolphin/src/kitemviews/kitemlistwidget.cpp http://commits.kde.org/kde-baseapps/34a7860714ad6cd1df088536b25d0fd492cc9b38 This seems to work now in 4.13.2. Thank you! (In reply to comment #13) > This seems to work now in 4.13.2. > > Thank you! Thanks for your feedback! :) What do you (and others) think about a fade-in/out effect for the selection toggle? Feel free to discuss it with us in https://git.reviewboard.kde.org/r/118395/ ;) |