| Summary: | Contact subscription requests re-appear after reconnect | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | Venky <venkythegeek> |
| Component: | kded-module | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ddomenichelli, kde.kfoar, kde, mail, mklapetek, ruchir.brahmbhatt, triggerhappyelite |
| Priority: | NOR | ||
| Version: | 0.4.1 | ||
| Target Milestone: | Future | ||
| Platform: | Chakra | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-kded-module/13b81af5cc8f79cbd4edd77dddd020078afec7fb | Version Fixed In: | 0.7.1 |
| Sentry Crash Report: | |||
|
Description
Venky
2012-04-12 19:50:05 UTC
The current implementation of adding contacts is broken somewhere upstream (the problem with repeated request) - everytime you deny any request, it reappears on next login. So it's most probably not the spammers trying to add you again and again, but rather a bug (see bug 290634). However we could still have an option to block those users (so new request -> Accept | Deny | Block), but I'm unsure if Telepathy supports blocking of users not in your roster... I remember Olli Salli telling us that would happen (two years ago at our first sprint). He seemed to imply that it's up to us to remember what we asked the user, but then when I tested denying a user it worked fine, so I thought they must have changed it. If you haven't talked to upstream yet, do so. *** Bug 298765 has been marked as a duplicate of this bug. *** *** Bug 302438 has been marked as a duplicate of this bug. *** Been looking at what's been going on:
- we call removePresencePublication (in TpQt)
- this has the code:
if (usingFallbackContactList) {
remove contact from group
} else {
call "Unpublish" [1]
}
[1]http://telepathy.freedesktop.org/spec/Connection_Interface_Contact_List.html#Method:Unpublish
I have no idea what a fallbackcontactlist is.. we should see if haze is that.
A quick grep of Empathy shows it never calls unpublish, despite this method existing tp-glib. Maybe they have a wrapper that does something else?
(In reply to comment #5) > I have no idea what a fallbackcontactlist is.. we should see if haze is that. > A quick grep of Empathy shows it never calls unpublish, despite this method > existing tp-glib. Maybe they have a wrapper that does something else? Contact lists can be exposed in two ways. The old way is to spawn a special channel of type ContactList (deprecated), which exposes the contacts using the Group interface of the channel. The new way is to use Conn.I.ContactList. Tp-Qt internally handles both types of contact lists. In this case, fallbackcontactlist means the old Channel.Type.ContactList. I expect tp-glib to have a similar abstraction mechanism. By running qdbus on haze, it looks like it is still using Channel.Type.ContactList. Not sure if this can cause trouble, though. I think this behavior is normal if the server doesn't store the user's choice. Thanks George. So it's taking a different but valid path, though clearly we (KTp or TpQt) aren't doing something quite right. Tasks (for anyone): - check everything does work in Empathy, and if running empathy once stops it appearing for us each time. - find out what Empathy does - find out what tp-glib does - fix it :D *** Bug 325326 has been marked as a duplicate of this bug. *** *** Bug 327640 has been marked as a duplicate of this bug. *** I don't have the time yet to check what Empathy and tp-glib does, but I can confirm that blocking the contact from Empathy will stop the subscription request from re-appearing after reconnect. Git commit 13b81af5cc8f79cbd4edd77dddd020078afec7fb by David Edmundson. Committed on 26/12/2013 at 15:06. Pushed by davidedmundson into branch 'kde-telepathy-0.7'. Block contacts when denying requests This prevents them from reappearing REVIEW: 114671 FIXED-IN: 0.7.1 M +9 -2 contact-request-handler.cpp http://commits.kde.org/telepathy-kded-module/13b81af5cc8f79cbd4edd77dddd020078afec7fb |