| Summary: | Gwenview crashes when reloading a .png that, when reloading, happens to be empty. [Gwenview::Document::loadingState, Gwenview::RasterImageView::loadFromDocument ] | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Tor Bellino <ariel> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | ab.kde, basinilya, benni, linux776, manuel.neumann, moraru69, solix4321, susundberg, webcoach101 |
| Priority: | NOR | ||
| Version: | 2.8.1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/gwenview/a105634dd43c626cf1841203650b97b6faf69910 | Version Fixed In: | 4.10 |
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Tor Bellino
2012-04-01 20:04:44 UTC
*** Bug 307982 has been marked as a duplicate of this bug. *** *** Bug 308640 has been marked as a duplicate of this bug. *** *** Bug 309127 has been marked as a duplicate of this bug. *** Here is a tar with 4 photos from which 1 is broken to test on: https://files.one.ubuntu.com/MRl8rEpUSMiqEIUZ2Rrkvw Created attachment 75215 [details]
New crash information added by DrKonqi
gwenview (2.8.5) on KDE Platform 4.8.5 (4.8.5) "release 2" using Qt 4.8.1
- What I was doing when the application crashed:
Updating an png file with an external editor while having gwenview open in the same directory.
-- Backtrace (Reduced):
#6 Gwenview::Document::loadingState (this=0x0) at /usr/src/debug/gwenview-4.8.5/lib/document/document.cpp:162
#7 0x00007f95d8edf166 in Gwenview::RasterImageView::loadFromDocument (this=0x868650) at /usr/src/debug/gwenview-4.8.5/lib/documentview/rasterimageview.cpp:196
#8 0x00007f95d8ed4519 in Gwenview::AbstractImageView::setDocument (this=0x868650, doc=...) at /usr/src/debug/gwenview-4.8.5/lib/documentview/abstractimageview.cpp:142
#9 0x00007f95d8ee08f3 in Gwenview::RasterImageViewAdapter::slotLoadingFailed (this=<optimized out>) at /usr/src/debug/gwenview-4.8.5/lib/documentview/rasterimageviewadapter.cpp:118
[...]
#11 0x00007f95d8ec8095 in Gwenview::Document::loadingFailed (this=<optimized out>, _t1=...) at /usr/src/debug/gwenview-4.8.5/build/lib/document.moc:179
*** Bug 306013 has been marked as a duplicate of this bug. *** Git commit a105634dd43c626cf1841203650b97b6faf69910 by Benjamin Löwe. Committed on 10/12/2012 at 20:20. Pushed by bennihill into branch 'master'. Fix for bug 297262 - Gwenview crashes when reloading a .png that, when reloading, happens to be empty. REVIEW: 107636 FIXED-IN: 4.10 M +3 -1 lib/documentview/abstractimageview.cpp M +10 -8 lib/documentview/rasterimageview.cpp M +15 -12 lib/documentview/svgviewadapter.cpp http://commits.kde.org/gwenview/a105634dd43c626cf1841203650b97b6faf69910 *** Bug 312077 has been marked as a duplicate of this bug. *** Cherry-picked the fix into KDE/4.9 (too much to compile to install 4.10)
It still crashes at:
void ViewMainPage::reload()
{
Document::Ptr doc = d->currentView()->document();
because d->currentView() returns NULL
Could you explain how to reproduce the crash? I opened a png file, overwrote it with an empty file and hit reload. But it didn't crash. (Branch KDE/4.9 with commit a105634dd43c626cf1841203650b97b6faf69910 applied.) Benny Hill, please look at #306013 . It was marked as a duplicate of this bug, but perhaps it's not. In my case, gwenview crashes when I click a folder without images in the folder tree sidebar Benny Hill, please look at #306013 . It was marked as a duplicate of this bug, but perhaps it's not. In my case, gwenview crashes when I click a folder without images in the folder tree sidebar and press F5 Thanks a lot. I could reproduce the crash and your diagnosis was right. I reopened bug #306013 and am closing this one again. You can find my proposed patch here: https://git.reviewboard.kde.org/r/108042/ *** Bug 318112 has been marked as a duplicate of this bug. *** |