Summary: | KMultiTabBar: Does not correctly handle Mac font sizes | ||
---|---|---|---|
Product: | [Unmaintained] kdelibs | Reporter: | Anton Rasmussen <amhrasmussen> |
Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | caulier.gilles, cfeck, michel.ludwig, mk-lists, pepik1978, rjvbertin |
Priority: | NOR | ||
Version: | 4.10.90 | ||
Target Milestone: | --- | ||
Platform: | MacPorts | ||
OS: | macOS | ||
Latest Commit: | http://commits.kde.org/kwidgetsaddons/44d6d6cfcfea5060bfe1676840f1df6e86c235e8 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
Screenschot from Kile on OSX showing overlapping elements
Screenshot of the open dialog showing overlapping elements Proposed patch Widget-style-changed |
Description
Anton Rasmussen
2012-03-26 12:14:54 UTC
Created attachment 69901 [details]
Screenschot from Kile on OSX showing overlapping elements
Created attachment 69902 [details]
Screenshot of the open dialog showing overlapping elements
Michael, in the Kile screen shot, which widget do you use for the view selectors? That's a KMultiTabBar. All the code can be found in https://projects.kde.org/projects/extragear/office/kile/repository/revisions/master/entry/src/widgets/sidebar.cpp *** Bug 258279 has been marked as a duplicate of this bug. *** see bug 333049 for another screenshot taken kate *** Bug 333049 has been marked as a duplicate of this bug. *** Created attachment 88336 [details]
Proposed patch
Marko, if you are still on kdelibs4, could you test this patch (backport of the one from the review request)?
(In reply to Christoph Feck from comment #8) > Marko, if you are still on kdelibs4, could you test this patch (backport of > the one from the review request)? Yes, I am still also working on KDE4, will do it as soon as my KF5 virtual OSX/CI machine is free to revive the Qt4/KDE4 system. Thanks for the patch! Christoph, I am sorry, but I have to say there was no change in the layout! The controls are still overlapping with this patch as they did 2 years ago. That is, if my assumption was correct that I do NOT need to re-build kate from source after installing the patched kdelibs version... --- However, when I DO re-build kate - after patching kdelibs - I see the strange effect that all KMultiTabBars *disappear* completely from the application! The tool views menu suddenly has only a single entry, i.e. "View/Tool Views/Show Sidebars", the other 4 entries - previously below an extra separator - have vanished for some reason. Hi there, any idea about how to proceed with this now? No idea. Without being able to use QMacStyle, it is next to impossible to debug. All this is not an issue if I do NOT use the "Macintosh (aqua)" theme. The standard KDE themes are fine (apart from a redraw glitch in pulldown menus) but best works QtCurve. *** Bug 347589 has been marked as a duplicate of this bug. *** Created attachment 92563 [details] Widget-style-changed I tried also on Fedora20, and: digikam-4.9.0-1.fc20.x86_64 Using KDE Development Platform 4.14.3 Unfortunately there is another bug " The process for the digikamalbums protocol died unexpectedly" In console looks like problems "Failed to list url; Failed to list dates.." I can't to add ANY file there :)( so I can't reach the right-click menu part (2) from picture: https://bugsfiles.kde.org/attachment.cgi?id=92553 On the other hand, the issue marked as (1) on above attachment is NOT overlapping on F20. > https://bugs.kde.org/show_bug.cgi?id=347589#c3 > I suspect a problem with KDELibs and widget styles. > Which one do you use exactly ? Look in Setup/Miscs page. None was selected as Widget style (even F20 has it empty) - Mac Aqua didn't help (and looks with same overlapping). Plastique is better - see on scrnsht (and Phase looks also good). Git commit 44d6d6cfcfea5060bfe1676840f1df6e86c235e8 by René J.V. Bertin. Committed on 09/06/2016 at 17:13. Pushed by rjvbb into branch 'master'. Fix an alignment issue under the OS X native "macintosh" style REVIEW: 128005 Committed from host : Portia.local M +2 -0 src/kmultitabbar.cpp http://commits.kde.org/kwidgetsaddons/44d6d6cfcfea5060bfe1676840f1df6e86c235e8 |