Bug 296589

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.26 Safari/535.11
Build Identifier: 

Due to some stuff happening

<apachelogger> I suppose tomahawk calls play() on resume, as indicated by documentation
<apachelogger> so that will do m_player->resume();
<apachelogger> which in turn only tells vlc to unpause
<apachelogger> oh ohoh
<apachelogger> ah yes
<apachelogger> that is why I hated it so much
<apachelogger>     connect(m_mediaObject, SIGNAL(playbackCommenced()), this, SLOT(updateVolume()));
<lfranchi> uhh
<lfranchi> so
<lfranchi> right fix?
<apachelogger> well
<apachelogger> the right fix is to not do that at all
<apachelogger> however I am not sure why we do this to begin with
<apachelogger> I mean
<apachelogger> it is necessary to set the volume on play
<apachelogger> also an AO has a volume regardless of whether it is attached to a MO
<apachelogger> however adding or removing an AO from a playing MO is not supported anyway, so by all degrees of sanity that signal should only be for starting playback
<apachelogger> and even then it does not make sense because an MO always has a libvlc player instance (as it is created in its ctor)
<apachelogger> so I believe what should be going on is setting the volume on path creation
<apachelogger> and even that we might only want to do when PA support is not active
<apachelogger> as otherwise we might be messing up PAs volume restoring
<apachelogger> coling: thoughts?
-*- lfranchi feels the words flying right over his head :P
<apachelogger> lfranchi: please remove https://projects.kde.org/projects/kdesupport/phonon/phonon-vlc/repository/revisions/master/entry/src/mediaobject.cpp#L116
<apachelogger> see if that fixes the issue
<lfranchi> ok
<lfranchi> just the emit?
<apachelogger> yah
<lfranchi> k
<lfranchi> apachelogger: works then
<apachelogger> righto, so we only need to find the right solution
<j-b> what is the issue?
<apachelogger> lfranchi: if it is not too much a hassle please file abug so I do not forget to poke colin
<lfranchi> apachelogger: what shall i put in the bug?
<apachelogger> irc log, something :P
<apachelogger> I only care about titles anyway

Reproducible: Always