| Summary: | Linux user input device ioctls missing wrappers | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Chase Douglas <chase.douglas> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | chase.douglas |
| Priority: | NOR | ||
| Version First Reported In: | 3.7.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| See Also: | https://launchpad.net/bugs/958095 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Add ioctl wrappers for linux user input devices
Add uinput ioctl wrappers |
||
Although I'm reporting the bug against Ubuntu's valgrind package because it's what I've tested with, the attached patch is against a trunk svn checkout. (In reply to comment #0) > Created attachment 69693 [details] > Add ioctl wrappers for linux user input devices This looks like a patch for XOrg, not for Valgrind. Did you get the right one? Comment on attachment 69693 [details]
Add ioctl wrappers for linux user input devices
Yes, the patch is bogus. I'll attach the patch I applied to the Ubuntu package.
Created attachment 72333 [details]
Add uinput ioctl wrappers
Committed, r12737. Thanks for the patch. I had to apply one of the hunks by hand -- I think it conflicted with some other recent ioctl commits. So it would be good if you could check over the commit to see it's OK. Thanks. I haven't built and tested it, but the committed change looks correct. Thanks! |
Created attachment 69693 [details] Add ioctl wrappers for linux user input devices The user input device ioctls defined in linux/uinput.h need wrappers because they either don't provide a third argument or they provide an int value instead of a pointer to a memory location.