Bug 296116

Summary:	Q_ASSERT(display); crashes
Product:	[Applications] konsole	Reporter:	Christoph Feck <cfeck>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	crash	CC:	rohan
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Christoph Feck 2012-03-16 00:03:39 UTC

Since commit 02ac6dbf4d102384c08ad6d364aacd2a204bc105 exiting Konsole I hit the assert in ViewManager.cpp::731

I tried changing dynamic_cast to the more correct qobject_cast, but it still asserts, so it looks like viewCloseRequest() is called with a widget that isn't a TerminalDisplay at all.

Comment 1 Jekyll Wu 2012-03-16 01:58:07 UTC

Git commit edd9d2cfdfd23ffea695452cfc404d8f9a4ce865 by Jekyll Wu.
Committed on 16/03/2012 at 02:50.
Pushed by jekyllwu into branch 'master'.

Revert "Use the appropriate casting"

The received QWidget has already been destroyed, so using dynamic_cast
or qobject_cast does not work.

Another stupid mistake by me !

This reverts commit 02ac6dbf4d102384c08ad6d364aacd2a204bc105.

M  +3    -1    src/ViewManager.cpp

http://commits.kde.org/konsole/edd9d2cfdfd23ffea695452cfc404d8f9a4ce865

Comment 2 Jekyll Wu 2012-03-16 14:09:49 UTC

*** Bug 296154 has been marked as a duplicate of this bug. ***