| Summary: | Custom presence widget hides the spinning widget | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | Daniele E. Domenichelli <ddomenichelli> |
| Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, me, mklapetek |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | Future | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-contact-list/19ebafedd3dea93aef6efeced15a9b2155b0cbbd | Version Fixed In: | 0.6.0 |
| Sentry Crash Report: | |||
| Attachments: |
The cropped out spinner
screenshot |
||
|
Description
Daniele E. Domenichelli
2012-01-23 18:00:32 UTC
You forgot the screenshot. Nevertheless, I'm not really convinced this is a bug. In fact, I think this is a feature. When you start typing, the text would be hidden by the wheel, making it hardly readable. Maybe, but a half cropped crappy spinner isn't a feature. Either all on or all off. Also I no longer get the constant spinning wheel thanks to my awesome fix. Do you? I disagree. If you'd hide it while spinning, it would create an "operation finished" impression, which is wrong. If you let over the lineedit, it covers the text. So visible in the background seems the best to me. The lineedit serves basically as a modal dialog. If you open a modal dialog, it usually covers part of its parent window. Created attachment 68115 [details]
The cropped out spinner
I agree with all the logic and sentiments, but I can't agree that the current situation looks nice. We could make the wheel shrink the lineedit then, so that the lineedit's width is less than the wheel's x value when the wheel is shown, make it full width when it's not. Created attachment 68116 [details]
screenshot
(In reply to comment #2) > Also I no longer get the constant spinning wheel thanks to my awesome fix. Do > you? yes, looks like it is fixed for me as well... Re-confirming that this is still present even with the new button to change the status, you could just hide the spinning animation while the presence bar is in edit mode We can just change account status icon (green circle on the left) instead of drawing that spinning overlay. That won't be animated. However could be interesting moving the spinner over the presence icon, so it will look the same as the presence applet. Git commit 19ebafedd3dea93aef6efeced15a9b2155b0cbbd by Roman Nazarenko. Committed on 03/03/2013 at 17:10. Pushed by romann into branch 'master'. busyOverlay now hides if presence chooser is editable. REVIEW: 109262 M +16 -4 global-presence-chooser.cpp M +1 -0 global-presence-chooser.h http://commits.kde.org/telepathy-contact-list/19ebafedd3dea93aef6efeced15a9b2155b0cbbd |