Bug 290930

Summary: Cannot resize gamut diagram vertically, only horizontally
Product: [Applications] digikam Reporter: DrSlony <bugs>
Component: ColorManagement-ViewsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: bugs, caulier.gilles, metzpinguin
Priority: NOR    
Version: 4.2.0   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a Version Fixed In: 4.11.0
Attachments: splitter.png

Description DrSlony 2012-01-08 03:27:01 UTC 
Version:           2.5.0 (using KDE 4.7.4) 
OS:                Linux

The gamut diagram can be resized horizontally by resizing the right panel. However, you cannot resize it vertically.

Reproducible: Didn't try



Expected Results:  
We should be able to resize it vertically by dragging the top of the box up.

http://i.imgur.com/QIuIe.png
Comment 1 DrSlony 2012-01-08 03:27:57 UTC 
http://i.imgur.com/QIuIe.png

I tried to make it bigger so I can take a nice screenshot of it (until the feature request for saving it to disk gets implemented) but I cannot resize it vertically, so it's very disproportionate.
Comment 2 DrSlony 2012-01-08 03:28:54 UTC 
Oops, wrong url for previous comment #1, here's the correct one: http://i.imgur.com/ZEtqD.png
Comment 3 DrSlony 2013-02-12 01:29:19 UTC 
Still cannot resize vertically in 3.0.0
Comment 4 DrSlony 2014-09-15 14:28:30 UTC 
Still valid for 4.2.0.
Comment 5 caulier.gilles 2015-05-10 16:55:15 UTC 
Maik,

Current implementation of CIETongueWidget is voluntary limited to resize content horizontally. 

It's a limitation in rules from preview widget plug in image properties sidebar. It's not a limitation of widget as well. Widget can be re-sized vertically of course.

I propose to use QScrollArea to host this widget and to permit to zoom in/out and pan over ICC profile content.

What do you think about ?

Gilles
Comment 6 Maik Qualmann 2015-05-11 20:40:17 UTC 
Gilles,

I find the best representation for the CIETongueWidget is square. What do you think?

diff --git a/libs/widgets/iccprofiles/cietonguewidget.cpp b/libs/widgets/iccprofiles/cietonguewidget.cpp
index 6c87e59..f309f4f 100644
--- a/libs/widgets/iccprofiles/cietonguewidget.cpp
+++ b/libs/widgets/iccprofiles/cietonguewidget.cpp
@@ -811,6 +811,8 @@ void CIETongueWidget::paintEvent(QPaintEvent*)
 void CIETongueWidget::resizeEvent(QResizeEvent* event)
 {
     Q_UNUSED(event);
+
+    setMinimumHeight(width());
     d->needUpdatePixmap = true;
 }

Maik
Comment 7 DrSlony 2015-05-11 20:43:04 UTC 
The best representation depends on the shape of the gamut and on the needs of the user.
Comment 8 caulier.gilles 2015-05-11 20:57:48 UTC 
Maik,

The square aspect ratio can be a good compromise as touch in code is very small...

At least it's better than previous solution which is not very elegant...

Gilles
Comment 9 DrSlony 2015-05-12 06:05:05 UTC 
I agree that it's an improvement and probably good enough.
Comment 10 Maik Qualmann 2015-05-12 18:01:28 UTC 
Created attachment 92561 [details]
splitter.png

Or insert a splitter and the user can change the size? The state of the splitter would be probably saved.

Maik
Comment 11 caulier.gilles 2015-05-13 08:39:02 UTC 
I tried square auto resize, and it's perfect and enough.

Gilles
Comment 12 Maik Qualmann 2015-05-13 10:37:14 UTC 
Git commit 3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a by Maik Qualmann.
Committed on 13/05/2015 at 10:35.
Pushed by mqualmann into branch 'master'.

set CIETongueWidget to square view
FIXED-IN: 4.11.0

M  +2    -1    NEWS
M  +1    -0    libs/widgets/iccprofiles/cietonguewidget.cpp

http://commits.kde.org/digikam/3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a
Comment 13 caulier.gilles 2015-05-13 11:48:28 UTC 
Git commit fedad652d305032959a45f626f5bd49c031a9e50 by Gilles Caulier.
Committed on 13/05/2015 at 11:47.
Pushed by cgilles into branch 'frameworks'.

backport commit #3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a from git/master to frameworks branch

M  +1    -0    libs/widgets/iccprofiles/cietonguewidget.cpp
M  +1    -1    libs/widgets/iccprofiles/cietonguewidget.h

http://commits.kde.org/digikam/fedad652d305032959a45f626f5bd49c031a9e50