| Summary: | details tree view no longer shows lines | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Martin Koller <kollix> |
| Component: | view-engine: details mode | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cfeck, chalkerx, m.wege, mmodem00, zander |
| Priority: | NOR | ||
| Version: | 1.99 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Sentry Crash Report: | |||
| Attachments: | screenshot of details view compared to treeview in kmail | ||
|
Description
Martin Koller
2011-12-31 18:29:33 UTC
Created attachment 67285 [details]
screenshot of details view compared to treeview in kmail
It is the same problem with the Oxygen style and the option "draw tree branch lines enabled", so it seems dolphin hardcoded disables the branch lines instead using what the user configured I would conclude, without actually checking, this is a missing feature in the itemviewsng component thats used in dolphin (and not (yet) in kmail). If my optimistic conclusion is correcct; I would suggest changing the severity to wishlist. If it is a missing feature in a reimplementation of a component, it is still a bug (regression) since with the previous implementation it worked fine. As Thomas concluded the implementation of the "draw tree branch lines" is currently simply missing in the view-engine of Dolphin. So Dolphin did not disable them on purpose (although I personally prefer having no lines but of course Dolphin should respect the current style and don't force anyone with my personal preferences ;-)). To me it is not so important whether this issue is classified as "wishlist" or "normal" bug. I agree here with Martin that it is a bug or (from a users point of view) even a regression. Peter, I am still looking at a jungle of files, can you point me to the place where the branch indicators are rendered, so that I can see if it is easy to add the tree lines? I failed to find "QStyle::PE_IndicatorBranch"... @Christoph: Thanks for your help, but sadly it is not that easy... Currently there is no information in the item which kind of indicator-branch must be drawn and all items are independent from each other. For getting the kind of indicator-branch also the information is required whether there is a successor item etc. I've done this kind of thing already twice for other projects and conceptually it is no big deal to get it done, but it is definitely something in the range of ~50 - 100 lines of code :-/ This was on my «to-complain on rc2 list» :-). (See bug #284646). Wanted to create a report today, but found it already reported. This looks like a regression to me. Dolphin details view should respect configuration in oxygen-settings. Lines and tree-buttons are configurable from there, but Dolphin 2.0 ignores those settings now. *** Bug 289089 has been marked as a duplicate of this bug. *** Can this be fixed before 4.8.0 release (to not introduce a regression)? No sorry, this cannot be fixed until the 4.8 release... We are in branch 4.8 for some time, why is still not possible to fix this bug? This is a regression since dolphin used to show a cross inside a litle box when i choosed the theme plastique. i dont know what name is used to call those litle crosses :) > We are in branch 4.8 for some time, why is still not possible to fix this bug? @Zé: As far as I know your following the KDE development since a few years already and seem to make daily builds, give feedback on kde-devel@kde.org. I'm really surprised about your question... At the moment Dolphin has 297 open bugs and 447 open wishes. There are a lot more important issues out there that needs to be fixed first before. The Dolphin team is very small and each member contributes the patches in their spare-time. This issue is a visual inconsistency that should be fixed, but it does not break the workflow for anybody and hence the priority is medium and not high to fix this. If you read comment #7 you will notice that a patch for this is not doable in a few minutes. Although fixing this is not tricky it will take several hours. And I won't spend several hours to fix a visual inconsistency if there are more serious issues out there that really are a problem for users. I understand but i dont think that this can be considered that trivial, at least in my POP (as for many other users) its very important the visual effect, just so that you know i prefer to go back to a SHA from end of July, than use dolphin 2.0, mainly because of this problem and the expandable folders. I dont get why you got surprised, this was a matter that i already discussed with you, still your opinion about whats more important to fix is the one that prevails so i need to continue to poke you some here, some there to see if you dont forget about it :) If i had the knowledge, joining dolphin team would be my first choice but maybe that day isnt that so far away... *** Bug 293764 has been marked as a duplicate of this bug. *** Git commit e505c3ae5a8df306992777b7ba121036a7d8933d by Peter Penz. Committed on 14/02/2012 at 18:04. Pushed by ppenz into branch 'KDE/4.8'. Details view: Fix indicator-branches Up to now no indicator-branches have been drawn when showing a tree. The patch fixes this so that that the style-dependent branches are drawn. The main part of the patch is the implementation of KItemListView::updateSiblingsInformation(). Most of the other changes are related due to an internal renaming of the expansionsLevel-role to expandedParentsCount and some related cleanups. FIXED-IN: 4.8.1 M +3 -3 dolphin/src/kitemviews/kfileitemlistview.cpp M +57 -20 dolphin/src/kitemviews/kfileitemlistwidget.cpp M +2 -0 dolphin/src/kitemviews/kfileitemlistwidget.h M +76 -68 dolphin/src/kitemviews/kfileitemmodel.cpp M +13 -12 dolphin/src/kitemviews/kfileitemmodel.h M +128 -0 dolphin/src/kitemviews/kitemlistview.cpp M +14 -0 dolphin/src/kitemviews/kitemlistview.h M +26 -7 dolphin/src/kitemviews/kitemlistwidget.cpp M +13 -0 dolphin/src/kitemviews/kitemlistwidget.h M +6 -0 dolphin/src/kitemviews/kitemmodelbase.cpp M +6 -0 dolphin/src/kitemviews/kitemmodelbase.h M +3 -3 dolphin/src/tests/kfileitemmodeltest.cpp http://commits.kde.org/kde-baseapps/e505c3ae5a8df306992777b7ba121036a7d8933d Git commit e2645b3a2bd0fbe99890e86acaa82a66cfb49b7f by Peter Penz. Committed on 14/02/2012 at 18:04. Pushed by ppenz into branch 'master'. Details view: Fix indicator-branches Up to now no indicator-branches have been drawn when showing a tree. The patch fixes this so that that the style-dependent branches are drawn. The main part of the patch is the implementation of KItemListView::updateSiblingsInformation(). Most of the other changes are related due to an internal renaming of the expansionsLevel-role to expandedParentsCount and some related cleanups. FIXED-IN: 4.8.1 M +3 -3 dolphin/src/kitemviews/kfileitemlistview.cpp M +57 -20 dolphin/src/kitemviews/kfileitemlistwidget.cpp M +2 -0 dolphin/src/kitemviews/kfileitemlistwidget.h M +76 -68 dolphin/src/kitemviews/kfileitemmodel.cpp M +13 -12 dolphin/src/kitemviews/kfileitemmodel.h M +128 -0 dolphin/src/kitemviews/kitemlistview.cpp M +14 -0 dolphin/src/kitemviews/kitemlistview.h M +26 -7 dolphin/src/kitemviews/kitemlistwidget.cpp M +13 -0 dolphin/src/kitemviews/kitemlistwidget.h M +6 -0 dolphin/src/kitemviews/kitemmodelbase.cpp M +6 -0 dolphin/src/kitemviews/kitemmodelbase.h M +3 -3 dolphin/src/tests/kfileitemmodeltest.cpp http://commits.kde.org/kde-baseapps/e2645b3a2bd0fbe99890e86acaa82a66cfb49b7f Wow, lots of code to bring the trees back :) Peter, your rate of fixing is fantastic, thanks! > Wow, lots of code to bring the trees back It's actually not that much as it looks like. But during implementing it I detected some related things that should be cleaned up and did this in the scope of this issue. But still it is of course no 3-liner patch ;-) > Peter, your rate of fixing is fantastic, thanks! Thanks :-) Some finetuning for this issue is still necessary but this should be finished until tomorrow. |