| Summary: | [PATCH] oxygenstyle fails to build (final): missing #include <fixx11h.h> | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | esigra |
| Component: | style | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hugo.pereira.da.costa |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch that fixes the build | ||
Git commit defc38b9e673cadc12315e32ef1583820a4a8bd8 by Hugo Pereira Da Costa. Committed on 05/01/2012 at 10:48. Pushed by hpereiradacosta into branch 'KDE/4.8'. Added missing header M +1 -0 libs/oxygen/oxygenhelper.cpp http://commits.kde.org/kde-workspace/defc38b9e673cadc12315e32ef1583820a4a8bd8 Git commit e4fce875f4cc2406f8ab53767b02301f8c9d385e by Hugo Pereira Da Costa. Committed on 05/01/2012 at 10:48. Pushed by hpereiradacosta into branch 'master'. Added missing header M +1 -0 libs/oxygen/oxygenhelper.cpp http://commits.kde.org/kde-workspace/e4fce875f4cc2406f8ab53767b02301f8c9d385e Fixed ! Thanks for posting the patch and sorry for the delay. Hugo |
Created attachment 67095 [details] patch that fixes the build Version: unspecified (using KDE 4.7.3) OS: Linux oxygenstyle fails to build with KDE4_ENABLE_FINAL=ON becasue a X11 header is included without the following #include <fixx11h.h>. Reproducible: Always Steps to Reproduce: 1. tar jxvf /usr/portage/distfiles/kde-workspace-4.7.3.tar.bz2 2. cd kde-workspace-4.7.3 3. mkdir build 4. cd build 5. cmake -DKDE4_ENABLE_FINAL=ON .. 6. make oxygenstyle Actual Results: In file included from /usr/include/qt4/QtCore/QUrl:1:0, from /usr/include/kurl.h:28, from /usr/include/KDE/../conversion_check.h:32, from /usr/include/KDE/../kconfiggroup.h:718, from /usr/include/KDE/KConfigGroup:1, from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowconfiguration.h:32, from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowcache.h:30, from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowcache.cpp:27, from kde-workspace-4.7.3.orig/build/libs/oxygen/oxygenstyle_final_cpp.cpp:5: /usr/include/qt4/QtCore/qurl.h:70:9: fel: expected identifier before numeric constant . . . Expected Results: successful build