Summary: | crash with gpsd not running | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | Anders Lund <anderslund> |
Component: | general | Assignee: | marble-bugs |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nienhueser, perezmeyer |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | 1.3 (KDE 4.8) | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | KDE 4.8.1 / Marble 1.3.1 |
Description
Anders Lund
2011-12-20 11:32:19 UTC
Git commit 2404dd076c9e44f140d8aba61cd0f45a84493969 by Dennis Nienhüser. Committed on 18/01/2012 at 19:13. Pushed by nienhueser into branch 'master'. Fix segfault with newer gpsd versions. This patch adds a check for the stream method in libgpsmm to return not NULL value. When that method returns NULL value, it's always should be treated as an error. No new calls introduced (despite the #if block moved), just added a check for one return value. Also see http://git.savannah.gnu.org/cgit/gpsd.git/commit/libgpsmm.cpp?id=ce15eae5b1170acebdbe88dd9a8a011a6d6957fb for explanation: «C++ clients should test the return from the stream method to see if the open succeeded.» This fixes a segfault on newer gpsd versions, and should not affect older versions. Patch by Nikita Skovoroda, thanks! CCMAIL: chalkerx@gmail.com REVIEW: 103717 M +5 -4 src/plugins/positionprovider/gpsd/GpsdConnection.cpp http://commits.kde.org/marble/2404dd076c9e44f140d8aba61cd0f45a84493969 Git commit f21ea05a7d69b96b2e4ca6b414d618210b8e1f9c by Dennis Nienhüser. Committed on 18/01/2012 at 19:13. Pushed by nienhueser into branch 'KDE/4.8'. Fix segfault with newer gpsd versions. This patch adds a check for the stream method in libgpsmm to return not NULL value. When that method returns NULL value, it's always should be treated as an error. No new calls introduced (despite the #if block moved), just added a check for one return value. Also see http://git.savannah.gnu.org/cgit/gpsd.git/commit/libgpsmm.cpp?id=ce15eae5b1170acebdbe88dd9a8a011a6d6957fb for explanation: «C++ clients should test the return from the stream method to see if the open succeeded.» This fixes a segfault on newer gpsd versions, and should not affect older versions. Patch by Nikita Skovoroda, thanks! CCMAIL: chalkerx@gmail.com REVIEW: 103717 (cherry picked from commit 2404dd076c9e44f140d8aba61cd0f45a84493969) M +5 -4 src/plugins/positionprovider/gpsd/GpsdConnection.cpp http://commits.kde.org/marble/f21ea05a7d69b96b2e4ca6b414d618210b8e1f9c Git commit 91fc3d70ec2af2217e99d867f6bef19bf828bf0c by Dennis Nienhüser. Committed on 18/01/2012 at 19:13. Pushed by nienhueser into branch 'Touch/1.3'. Fix segfault with newer gpsd versions. This patch adds a check for the stream method in libgpsmm to return not NULL value. When that method returns NULL value, it's always should be treated as an error. No new calls introduced (despite the #if block moved), just added a check for one return value. Also see http://git.savannah.gnu.org/cgit/gpsd.git/commit/libgpsmm.cpp?id=ce15eae5b1170acebdbe88dd9a8a011a6d6957fb for explanation: «C++ clients should test the return from the stream method to see if the open succeeded.» This fixes a segfault on newer gpsd versions, and should not affect older versions. Patch by Nikita Skovoroda, thanks! CCMAIL: chalkerx@gmail.com REVIEW: 103717 (cherry picked from commit 2404dd076c9e44f140d8aba61cd0f45a84493969) M +5 -4 src/plugins/positionprovider/gpsd/GpsdConnection.cpp http://commits.kde.org/marble/91fc3d70ec2af2217e99d867f6bef19bf828bf0c *** Bug 300213 has been marked as a duplicate of this bug. *** |