Summary: | manual-update and manual-build do not work for KDE project module-sets. | ||
---|---|---|---|
Product: | [Developer tools] kdesrc-build | Reporter: | Michael Pyne <mpyne> |
Component: | general | Assignee: | Michael Pyne <mpyne> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fredrick.o.jackson, progettoarx |
Priority: | NOR | ||
Version: | Git | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 1.15 |
Description
Michael Pyne
2011-12-09 23:22:00 UTC
Hmm, seems at some point duplicate module option consolidation got removed. I'll be re-adding this as it is a very useful feature to have when reading options for module sets. Git commit 2f29db0ed9c5692513838941091ae226c12bdbfc by Michael Pyne. Committed on 14/01/2012 at 04:20. Pushed by mpyne into branch 'master'. Ensure module options override module-set options for same module. It has always been the intention since module-set was introduced that it would be possible to override options set for a module used in that module-set by making a later module declaration, without that later module declaration actually changing the build order or making any other effect. This feature was broken and reported as a bug. I've added a testcase to reproduce the problem, and I have fixed it by passing back to parse_module() existing Module objects when present, and modified parse_module() to not create new Module objects in that case but to modify the one provided. I've also added a warning for modules that do not appear to be part of a module set as this indicates duplicate modules passed in the config file. As of right now the way this test works is to look for a module-set name but those are optional, so what I'll probably do is auto-generate a module-set name based on the line number. That will come later though. FIXED-IN:1.15 M +42 -8 kdesrc-build M +7 -0 kdesrc-build-test.pl http://commits.kde.org/kdesrc-build/2f29db0ed9c5692513838941091ae226c12bdbfc |