| Summary: | The plasma_applet_notes plasmoid does not change the color. | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Manuel Tortosa <manutortosa> |
| Component: | widget-notes | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | annma, thelwyn |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Chakra | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Manuel Tortosa
2011-12-05 20:37:44 UTC
Hi, do you add the widget on the desktop or on the dashboard? There have been a few reports about the color of notes not changing on the dashboard, but it was always working on the desktop in these cases. Fails on both dashboard and desktop. Actually after cnanging the colour the rc file looks like this: [Containments][46][Applets][49][Configuration] Share=false autoSaveHtml=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">\n<html><head><meta name="qrichtext" content="1" /><style type="text/css">$ color=yellow-notes scrollValue=0 so somehow the config is not being written to plasma-desktop-appletsrc what plasma desktop (svg) theme are you using? Plain vanilla kde config "Air" but does not matter. using another theme (i tried like 5) i get the same results, with or without composition. Git commit 2ee0a40f0422fe49cb8825ef3b6bedfb239eb4ce by Anne-Marie Mahfouf. Committed on 07/12/2011 at 13:06. Pushed by annma into branch 'master'. set the changed Notes color BUG: 288286 M +1 -2 applets/notes/notes.cpp http://commits.kde.org/kdeplasma-addons/2ee0a40f0422fe49cb8825ef3b6bedfb239eb4ce Sorry but i backported the commit to the 4.8 beta 2 tarball and does not seems to fix nothing. The colour does not change. Theorically the default colour in the drop-down list is white but the note appear as yellow. After changing the colour and apply, the colour still remains yellow. As you can see in the rc, the color value never changes from yellow-notes, does not matter the color i choose: [Containments][46][Applets][64] geometry=1180,378,256,256 immutability=0 plugin=plasma_applet_notes zvalue=114 [Containments][46][Applets][64][Configuration] Share=false autoSaveHtml=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">\n<html><head><meta name="qrichtext" content="1" /><style type="text/css">$ color=yellow-notes scrollValue=0 textColor=195,195,195 useThemeColor=true Sorry yes, I tested with the right click menu and the setting is written but in fact not kept and then I discovered the combobox setting and this one does not work at all. In the code m_topWidget->color() stays at "yellow-notes" and what I thought would be a trivial fix is a bit more complicated. I'll look deeper in it and meanwhile I'm reopening this report. Thanks, will follow this issue. Request me any testing in this regard, will be glad to backport and test any commit. Manuel, thanks for the help in testing, here is a patch on reviewboard https://git.reviewboard.kde.org/r/103353/ Should also address https://bugs.kde.org/show_bug.cgi?id=249174 Will review right now and put a ship it if works. Thanks. You can apply and close both. thanks a lot. Git commit acb4d203d1d2e5ac3cad3be5bc2a13cddf4fc9d2 by Aaron Seigo. Committed on 08/12/2011 at 10:32. Pushed by aseigo into branch 'master'. porting with scripts is like running with scissors BUG:288286 REVIEW:103353 M +12 -9 applets/notes/notes.cpp http://commits.kde.org/kdeplasma-addons/acb4d203d1d2e5ac3cad3be5bc2a13cddf4fc9d2 |