Summary: | Fails to scrobble to last.fm when track has no composer and "scrobble composer" setting is on | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Илья Казначеев <ilya.kasnacheev> |
Component: | Services/Last.fm | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | dmeltzer.devel, kde, lfranchi |
Priority: | NOR | ||
Version: | 2.4.3 | ||
Target Milestone: | 2.6 | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.5 | |
Attachments: | This patch fixes the issue and also refactors a bit |
Description
Илья Казначеев
2011-11-09 20:16:33 UTC
This is really a corner case. I listen to classical music a lot, but don't use the composer scrobbling, as it usually doesn't give coherent results in last.fm, their datsbase is not really made for classical music. The problem is clicking the option accidentallly. You'll spend a week never knowing what hit you. Created attachment 66122 [details]
This patch fixes the issue and also refactors a bit
This patch fixes the issue by checking whether the composer is empty and falling back to performer.
I've also refactored out repetitive track-populating code into a method.
Thank you for the patch. Please submit it for review to http://reviewboard.kde.org. You will need to get an identity from http://identity.kde.org first. Git commit f9feaf51acfca9eb9994123ffb1929c65d99aa23 by Sam Lade. Committed on 28/11/2011 at 03:40. Pushed by lade into branch 'master'. Fix last.fm scrobble composer fallback to artist Now correctly scrobbles with the artist name if the composer field is empty and the scrobble composer option is enabled, rather than silently failing. Patch by Ilya Kasnacheev. BUG:286215 FIXED-IN:2.5 REVIEW:103279 M +1 -0 ChangeLog M +27 -25 src/services/lastfm/ScrobblerAdapter.cpp M +2 -1 src/services/lastfm/ScrobblerAdapter.h http://commits.kde.org/amarok/f9feaf51acfca9eb9994123ffb1929c65d99aa23 |