Bug 284662

Version:           unspecified (using Devel) 
OS:                Linux

Hi,
at the top of the advancedDiscDetect() function it says original code was http://cgit.freedesktop.org/hal/tree/hald/linux/probing/probe-volume.c ... that file however skips the check for advanced content:
> 		/* Suggested by Alex Larsson to get rid of log spewage
> 		 * on Alan's cd changer (RH bug 130649) */
> 		if (ioctl (fd, CDROM_DRIVE_STATUS, CDSL_CURRENT) != CDS_DISC_OK) {
> 			goto out;
> 		}
> 
> 		/* check for audio/data/blank */
> 		type = ioctl (fd, CDROM_DISC_STATUS, CDSL_CURRENT);
> 		switch (type) {
> 		case CDS_AUDIO:		/* audio CD */
> 			libhal_changeset_set_property_bool (cs, "volume.disc.has_audio", TRUE);
> 			HAL_DEBUG(("Disc in %s has audio", device_file));
> 			should_probe_for_fs = FALSE;
> 			break;
> 		case CDS_MIXED:		/* mixed mode CD */
> 			libhal_changeset_set_property_bool (cs, "volume.disc.has_audio", TRUE);
> 			libhal_changeset_set_property_bool (cs, "volume.disc.has_data", TRUE);
> 			HAL_DEBUG(("Disc in %s has audio+data", device_file));
> 			break;
> 		case CDS_DATA_1:	/* data CD */
> 		case CDS_DATA_2:
> 		case CDS_XA_2_1:
> 		case CDS_XA_2_2:
> 			libhal_changeset_set_property_bool (cs, "volume.disc.has_data", TRUE);
> 			HAL_DEBUG(("Disc in %s has data", device_file));
> 			advanced_disc_detect (cs, fd, device_file);
> 			break;
as the current solid udisk backend does not do this, it spews error to stdout AS LONG AS AN AUDIO CD IS INSERTED for ANY KDE app that uses the places bar - even if only in open/save dialogs.

Reproducible: Didn't try

Steps to Reproduce:
start dolphin, konqueror, amarok, file open/save dialog in any other kde app 

Actual Results:  
Advanced probing on /dev/sr0 failed while reading block size
and again
and again
and again
and again
repeat

Expected Results:  
advancedDiscDetect() should not be invoked on Audio-only discs *at all*

OS: Linux (x86_64) release 3.1.0-rc9-00064-g65112dc-dirty
Compiler: x86_64-pc-linux-gnu-gcc