| Summary: | When packing multiple selected files - use containing folder name | ||
|---|---|---|---|
| Product: | [Applications] ark | Reporter: | Victor Varvaryuk <victor.varvariuc> |
| Component: | general | Assignee: | Elvis Angelaccio <elvis.angelaccio> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | arthur, florian.schunk, hashhar, razrfalcon |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 2.16 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/ark/80080c9e8eb2d4c51a1195190182026e0a78a035 | Version Fixed In: | 15.12.3 |
| Sentry Crash Report: | |||
| Attachments: |
Ark automatically names the archive by first selected file
Similar happens when using 'Compress to...' patch |
||
Created attachment 62741 [details]
Similar happens when using 'Compress to...'
When in a folder i select multiple files to pack [Context Menu -> Compress ->
Compress to...] Ark opens a dialog without suggesting a name of the archive - which should be name of the containing folder.
Created attachment 85614 [details]
patch
Hi Florian, Thanks for the patch. Please send it via ReviewBoard [1], which is what we use for code review. [1] http://techbase.kde.org/Reviewboard Glancing over the patch: please adjust the coding style (there are some extra empty lines, a comment that starts with a lowercase character, has no leading space and no period at the end and the operator in the if is not surrounded by spaces). If in doubt, follow the style of the surrounding code or take a look at http://techbase.kde.org/Policies/Kdelibs_Coding_Style, which we also use in Ark. Cheers! *** Bug 306288 has been marked as a duplicate of this bug. *** Florian, any progress with comment #3? (In reply to comment #5) > Florian, any progress with comment #3? We're tracking it in https://git.reviewboard.kde.org/r/116890/ Git commit 80080c9e8eb2d4c51a1195190182026e0a78a035 by Elvis Angelaccio, on behalf of Chantara Tith. Committed on 10/03/2016 at 22:24. Pushed by elvisangelaccio into branch 'Applications/15.12'. Use containing-folder name when packing multiple selected files FIXED-IN: 15.12.3 Differential Revision: D1111 M +19 -4 kerfuffle/addtoarchive.cpp M +1 -0 kerfuffle/addtoarchive.h http://commits.kde.org/ark/80080c9e8eb2d4c51a1195190182026e0a78a035 |
Created attachment 62740 [details] Ark automatically names the archive by first selected file Version: 2.16 (using KDE 4.7.0) OS: Linux Version 2.17 When in a folder i select multiple files to pack [Context Menu -> Compress -> As ZIP Archive] Ark automatically names the archive by first selected file. WinRAR uses in such cases name of the containing folder. Reproducible: Always Expected Results: If i select two files inside a folder called 'Test', the archive of them is called 'Test.zip'