Bug 279018

Summary:	Sun shadow incorrect for some themes
Product:	[Applications] marble	Reporter:	Bernhard Beschow <shentey>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	1.3 (KDE 4.8)
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Bernhard Beschow 2011-08-01 11:00:22 UTC

Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

The sun shading assumes a base tile layout of 1x2 tiles. As a result, the sun shading is incorrect for themes such as OSM.

Reproducible: Always

Steps to Reproduce:
Activate View->Sun Contol->Sun Shading->Shadow.

Actual Results:  
Shadow and sun regions don't follow the form of a wave because they are too wide.

Expected Results:  
Shadow and sun regions should follow the form of a "wave".

Comment 1 Bernhard Beschow 2011-08-01 12:25:25 UTC

Git commit 9744ed0a14f203ba5ad7badeae1d02528aea8117 by Bernhard Beschow.
Committed on 29/07/2011 at 17:22.
Pushed by beschow into branch 'kde-4.7'.

fix sun shading to use correct number of base tiles

BUG: 279018

M  +5    -0    src/lib/MergedLayerDecorator.h
M  +6    -1    src/lib/StackedTileLoader.cpp
M  +11   -6    src/lib/MergedLayerDecorator.cpp

http://commits.kde.org/marble/9744ed0a14f203ba5ad7badeae1d02528aea8117

Comment 2 Bernhard Beschow 2011-08-01 13:16:32 UTC

Git commit 2abd29ecf60782c64da4bc733536975da0c03979 by Bernhard Beschow.
Committed on 29/07/2011 at 17:22.
Pushed by beschow into branch 'master'.

fix sun shading to use correct number of base tiles

BUG: 279018

(cherry picked from commit 9744ed0a14f203ba5ad7badeae1d02528aea8117)

M  +4    -0    src/lib/MergedLayerDecorator.h
M  +5    -1    src/lib/StackedTileLoader.cpp
M  +14   -14   src/lib/MergedLayerDecorator.cpp

http://commits.kde.org/marble/2abd29ecf60782c64da4bc733536975da0c03979