| Summary: | [2.0] Context menu > Assign Tags > Recently assigned tags not preserved between session and fixed size | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | julien.t43+kde |
| Component: | Database-Albums | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 2.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.7.0 | |
| Sentry Crash Report: | |||
|
Description
julien.t43+kde
2011-07-23 16:55:16 UTC
This information must be stored in DB between session. But it's not already the case Marcel ? Gilles Caulier Other question ? When the list must be cleared ? An action from user in contextual menu ? Gilles Caulier AMHA * resetting between session could be an option * manually clearing menu should be available in context menu as gilles said. No, it's not in the database. I would suggest to store it in the settings file. bug still valid in 2.2.0/4.6.5 Julien, It still valid using digiKam 2.4 ? Gilles Caulier Hello Gilles, sorry unable to test for now as there is no update in ppa and it seems Philipp will not provide them for ubuntu natty/11.04. I delayed my update to 11.10 because of gnome3/unity polemic and some failed upgrade reports. Not sure when I will be able to test. If someone else can give feedback, I'll give mine as soon as I can but not probably before one week, so I can I have time to manage a smooth upgrade or change distribution if not happy with latest ubuntu. NOK. tested today with digikam 2.5.0/kde 4.6.5 from Philips' PPA NOK ? Not okay for you ? yes, not ok. not working. after tagging few pictures, restarted digikam, empty context menu. Git commit 31fb43e49ac8b938c2d41a00e0ffb065868d94c1 by Andi Clemens. Committed on 22/04/2012 at 16:12. Pushed by aclemens into branch 'master'. Preserve recently assigned / used tags This commit contains a dirty hack, because writeSettings() is called every time a tag was added / removed to an image. This is currently needed because the destructor of the AlbumDB object is never called. Setting a breakpoint in its destructor shows that it never reaches the code. Marcel, is this a problem, besides possibly having a memory leak here? Andi CCMAIL:marcel.wiesweg@gmx.de M +33 -3 libs/database/albumdb.cpp M +6 -0 libs/database/albumdb.h http://commits.kde.org/digikam/31fb43e49ac8b938c2d41a00e0ffb065868d94c1 I also noticed that assigning tags doesn't work at all for me, I get the info "writing metadata" and it never closes this background task. When I close digiKam, I need to explicitly kill the background task! Is writing of metadata currently broken? Andi (In reply to comment #12) > I also noticed that assigning tags doesn't work at all for me, I get the > info "writing metadata" and it never closes this background task. > When I close digiKam, I need to explicitly kill the background task! > Is writing of metadata currently broken? There is a bug report for this. I have not yet been able to reproduce the problem, it works for me updated to 2.6.0/ubuntu ppa. short test: start digikam, assign a tag, quit, restart, check menu => working. will add comments if I find it not working in coming weeks. Thanks. |