Bug 275544

Summary:	[patch] kdevplatform does not build with KDEENABLEFINAL
Product:	[Developer tools] kdevplatform	Reporter:	Andreas K. Huettel <dilfridge>
Component:	general	Assignee:	kdevelop-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, esigra, nalvarez
Priority:	VHI
Version:	1.2.0
Target Milestone:	1.2.0
Platform:	Gentoo Packages
OS:	Linux
URL:	https://bugs.gentoo.org/show_bug.cgi?id=360759
Latest Commit:		Version Fixed In:
Attachments:	make kdevplatform build with KDEENABLEFINAL

Description Andreas K. Huettel 2011-06-13 13:05:00 UTC

Created attachment 60958 [details]
make kdevplatform build with KDEENABLEFINAL

When KDEENABLEFINAL is set, kdevplatform-1.2.0 fails to build. One of our Gentoo users experienced with that setting created a patch, which I am passing on to you here for review and integration.

From the linked Gentoo bugreport:

Erik 2011-03-27 13:59:58 CEST

Created attachment 267383 [details]
patch that fixes the build

This patch fixes errors in kdevplatform 1.2.0 so that it can be built:
* Define metatypes in header files and include them instead of having multiple
Q_DECLARE_METATYPE(TYPE) for the same TYPE (see
http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).
* Explicit static casts where needed according to the compiler.
* Define urlToData in one place only (a separate new header file).
* Rename one of the functions appendActions to appendContextMenuActions to make
the signature unique.
* Add include guard to greputil.h
* Rename one of the structs Visitor to selfAnalysisVisitor to make the
identifier unique.
* Use a unique include guard in appendlist_static.h (not the same as in
appendlist.h)
* Undefine the macro "mix" after use to not pollute the namespace.

Comment 1 Milian Wolff 2011-06-17 23:18:22 UTC

thanks, if possible put such things on our reviewboard in future (git.reviewboard.kde.org).

Comment 2 Nicolás Alvarez 2011-06-17 23:39:48 UTC

For the record, kdelibs doesn't build with FINAL either ;)

Comment 3 Aleix Pol 2011-08-07 07:07:15 UTC

Master is not compiling right now, mostly because these QFlags problem. Does anybody know where is it coming from? the static casts mentioned in the bug report.

Comment 4 Milian Wolff 2012-01-20 15:23:58 UTC

I think this was fixed by Nicolas recently, please reopen if it's still an issue.

Cheers