| Summary: | Problems with Removing non-jabber contacts | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | George Goldberg <grundleborg> |
| Component: | contactlist | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | 0.4.0 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
George Goldberg
2011-04-11 12:09:59 UTC
Just adding some comments from a discussion in IRC a while back. The problem could be that ContactManager::allKnownContacts() doesn't only return items in the buddy list. It returns everyone you've got some record on the server with. For the buddy list we only want to show contacts for whom we have a presenceSubscriptionState. This could be done either in the model itself (ask boiko first) or simply as a fixed part of our filter model. There is a talk of this being really easy to do in future telepathy with something like AccountSet but for Contacts. Based on that, I would choose the add it to our filter model option as it's a much faster/easier as a temporary hack. Just tested this in butterfly (0.5.15) Even after calling contactManager->removeContact(someContact); someContact.subscriptionState still returns PresenceStateYes; Therefore the proposed fix above will do nothing. Just tried in Empathy. Removed a contact from MSN with no problems/errors/issues at all. This contact was also immediately removed from my KDE list. This shows: KDE Telepathy Contact List code that displays users works fine. Telepathy-Butterfly works fine. The implication is that telepathy-Qt4 behaves differently to whatever "removing" code empathy does. Assigning to me for investigation. Removing from the list of blocking bugs on telepathy release. Just tested on my MSN account in Haze and everything worked fine. This was probably a butterfly bug and therefore no longer relevant. |