| Summary: | Crtl + Shift + S clash with okularpart | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Anders Lund <anderslund> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adawit |
| Priority: | NOR | ||
| Version: | 0.13.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
3 x CRTL + SHIFT + S standard shortcuts
patch: don't abuse saveas standard action |
||
|
Description
Anders Lund
2011-03-15 11:00:18 UTC
Sorry, but in the stock KDE distribution (4.7 branch), neither Konqueror nor Okular assign "Ctrl+Shift+S" as a shortcut to anything. Are you sure you did not assign this shortcut yourself and forgotten about it ? Can you check to see which application has this shortcut assigned ? I checked both and neither one use this shortcut on my system by default. Created attachment 65837 [details]
3 x CRTL + SHIFT + S standard shortcuts
As can be seen from this screenshot, khtml uses CTRL + SHIFT + S once (relevant when a pdf is opened in a frame (sic!)), and okular twice (!!) - okular is ALWAYS broken in this respect.
I can see that this is not so much a problem of konqueror, although it shows up there. Of course I am sure that khtml as well as okular uses widget context for those actions ;) So the problem must be in okular, and thus I redirect there. "Save As" has no standard shortcut as you can see in kstandardshortcut.cpp:152
{ SaveAs , "SaveAs" , I18N_NOOP2("@action", "Save As") , 0 , 0, KShortcut(), false },
You might want to use a proper distribution before filing bugs that contain !!!! in them
OTOH i seriously doubt there is any bug here (and if there is, it is due to Qt4 sucking in this regard, i'm sure with the QtProject they are waiting for your patches) and much more i doubt it's an Okular bug. What do you expect konqueror to do if you assing Ctrl+Shift+S to three different actions, read your mind?
Sure, being rude and patronizing towards me as well as the distribution I use is an execellent way of solving down problems. So pleasurable. If you look at the screenshot, it should be obvious that those are set as standard. It is set as standard, because I have set Ctrl + Shift + S as shortcut for "save as" in the systemsettings module for standard shortcuts. I assume we want to keep that configurability? The bug is that you use "save as" twice in the same widget, so *you* force that problem on anyone wanting to have a shortcut for save as. Quite easy to fix, luckily. Created attachment 65888 [details]
patch: don't abuse saveas standard action
Here is even a patch, untested though since i do not build kde here.
Git commit 432b7376e8f9c8f1b77c6cb074ea828920167a81 by Albert Astals Cid. Committed on 21/11/2011 at 23:31. Pushed by aacid into branch 'KDE/4.7'. Set the shortcut to false Since we are going to use KStandardAction::saveAs again later for the "real" 'Save As...'. This was working fine since there is no default shortcut for SaveAs but if the user sets one in the global kde config then he gets duplicate shortcut problems BUGS: 268551 M +1 -0 part.cpp http://commits.kde.org/okular/432b7376e8f9c8f1b77c6cb074ea828920167a81 Git commit 395d7163f650654bb6424c098bd277a2848a67b8 by Albert Astals Cid. Committed on 21/11/2011 at 23:34. Pushed by aacid into branch 'master'. Set an empty shortcut to Save copy as Since we are going to use KStandardAction::saveAs again later for the "real" 'Save As...'. This was working fine since there is no default shortcut for SaveAs but if the user sets one in the global kde config then he gets duplicate shortcut problems BUGS: 268551 M +1 -0 part.cpp http://commits.kde.org/okular/395d7163f650654bb6424c098bd277a2848a67b8 |