Bug 268316

Summary:	OK button not disabled on empty image list, following progress dialog never finishes [patch]
Product:	[Applications] digikam	Reporter:	Michael G. Hansen <mike>
Component:	Plugin-Generic-SendByMail	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, max7442
Priority:	NOR	Keywords:	junior-jobs
Version:	5.6.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.0.0
Sentry Crash Report:
Attachments:	Disable OK button when no image in ImagesList

Description Michael G. Hansen 2011-03-12 21:34:39 UTC

Version:           2.0.0 (using Devel) 
OS:                Linux

Start the "Send images" kipi plugin with some images. Then remove all images from the list. The OK button is not disabled. When clicking on the OK button, a progress dialog opens with a "Cancel" button, but no progress is made.

Reproducible: Always

Comment 1 Max Lin 2011-03-30 06:14:52 UTC

Created attachment 58451 [details]
Disable OK button when no image in ImagesList

This patch could disable OK button when no image in list, it's works fine on my machine. This is my first patch for KDE, so please take a look it and give me more advice.

Thanks,

Comment 2 caulier.gilles 2011-03-30 06:56:27 UTC

Thanks I will take a look today...

Gilles Caulier

Comment 3 caulier.gilles 2011-03-30 08:59:26 UTC

Max,

The patch is fine. A method can be simplified like this :

void SendImagesDialog::slotImagesCountChanged()
{
    enableButtonOk(!d->imagesPage->imagesList().isEmpty());
}

Gilles Caulier

Comment 4 caulier.gilles 2011-03-30 09:26:01 UTC

Git commit 279199ef2c04252aa00b20d58f77ceff6221e6b4 by Gilles Caulier.
Committed on 30/03/2011 at 09:27.
Pushed by cgilles into branch 'master'.

apply patch #58451 from MAx Lin
More private internal containers
BUGS: 268316

M  +12   -12   sendimages/emailpage.cpp     
M  +2    -3    sendimages/emailpage.h     
M  +3    -1    sendimages/emailsettingscontainer.h     
M  +2    -2    sendimages/imageresize.cpp     
M  +2    -3    sendimages/imageresize.h     
M  +2    -2    sendimages/imagespage.cpp     
M  +2    -2    sendimages/imagespage.h     
M  +6    -6    sendimages/plugin_sendimages.cpp     
M  +3    -5    sendimages/plugin_sendimages.h     
M  +8    -8    sendimages/sendimages.cpp     
M  +4    -4    sendimages/sendimages.h     
M  +18   -10   sendimages/sendimagesdialog.cpp     
M  +5    -5    sendimages/sendimagesdialog.h     

http://commits.kde.org/kipi-plugins/279199ef2c04252aa00b20d58f77ceff6221e6b4