| Summary: | PowerDevil "Disable Desktop Effects" setting is ignored during KDE start | ||
|---|---|---|---|
| Product: | [Unmaintained] solid | Reporter: | timshel <timshel> |
| Component: | powermanagement | Assignee: | Dario Freddi <drf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | barghest, kwin-bugs-null, wakkas.m, yasuna |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
timshel
2011-03-07 23:17:06 UTC
It is possible that the power daemon tries to disable compositing but KWin hasn't started yet. Adding kwin maintainers to check if we have a way to get informed when KWin is ready to receive D-Bus commands. like QDBusAbstractInterface::isValid()? However a) kwin has only a dbus function to check for the compositing state & one to toggle it - none to explicitly set a mode (this would be nice anyway) b) kwin is sometimes confused about whether compositing is currently active/enabled No idea how powedevil handles this but as for now it has to either disable compositing /before/ kwin is up or suspend compositing /after/ kwin is up. Also see https://git.reviewboard.kde.org/r/100767/ and please provide information about what powerdevil does or requires. In this bug report: https://bugs.kde.org/show_bug.cgi?id=274048 Martin Gräßlin says that compositing is actually less stressful on your battery than disabling it.. No! He says that TURNING OFF compositing (eg. because the battery is low) is more stressful than just leaving it because of the implications of this action (plasma theme reload, svg rendering, rerender every client to onscreen buffer, ...) This is only about: "what's best ACTION when your battery is very low." It does probably not hold for the longtime STATE and rather certainly not with OpenGL compositing. You're right.. My bad.. *** Bug 266104 has been marked as a duplicate of this bug. *** *** Bug 276191 has been marked as a duplicate of this bug. *** Git commit a22b5ea79087a1b0286fe223492dbac4fe67ccec by Dario Freddi. Committed on 30/09/2011 at 12:20. Pushed by dafre into branch 'master'. Removing Disable Desktop Effects in 4.8. Besides the fact this feature has never worked correctly, Martin confirmed it is no longer useful, but instead harmful, for how compositing is handled in 4.8+. CCMAIL: mgraesslin@kde.org BUG: 267924 BUG: 281240 M +0 -1 powerdevil/daemon/CMakeLists.txt M +0 -1 powerdevil/daemon/actions/bundled/CMakeLists.txt D +0 -105 powerdevil/daemon/actions/bundled/disabledesktopeffects.cpp D +0 -55 powerdevil/daemon/actions/bundled/disabledesktopeffects.h D +0 -99 powerdevil/daemon/actions/bundled/disabledesktopeffectsconfig.cpp D +0 -55 powerdevil/daemon/actions/bundled/disabledesktopeffectsconfig.h D +0 -114 powerdevil/daemon/actions/bundled/powerdevildisabledesktopeffectsaction.desktop M +0 -3 powerdevil/daemon/powerdevilactionpool.cpp http://commits.kde.org/kde-workspace/a22b5ea79087a1b0286fe223492dbac4fe67ccec |