Bug 265446

Summary:	Linking fails because of missing libs in CMakeLists.txt
Product:	[Unmaintained] telepathy	Reporter:	Martin Klapetek <mklapetek>
Component:	text-ui	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde
Priority:	NOR
Version:	git-latest
Target Milestone:	0.4.0
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Diff with added libs

Description Martin Klapetek 2011-02-04 19:56:21 UTC

Version:           svn-playground (using KDE 4.6.0) 
OS:                Linux

Fedora has introduced new DSO-linking semantics of the gcc compiler, which basically needs all linked-to libs explicitly specified, see http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking for more details. Other distros slowly follows this change.

The libs missing are libQtXml and libkio, adding them directly to the CMakeLists.txt target_link_libraries() makes the linking ok, though I guess they should be added in a different way (using modules?). See the attached diff for details

Reproducible: Always

Comment 1 Martin Klapetek 2011-02-04 19:57:14 UTC

Created attachment 56866 [details]
Diff with added libs

Comment 2 David Edmundson 2011-03-01 15:09:20 UTC

Not accepting your patch directly because you're not using the KDE macros (i.e ${KDE_KIO_WHATEVER_IT_IS} should be used instead of just kio.

However I think we have fixed this all now in a recent commit. Could you check?

Comment 3 Martin Klapetek 2011-03-01 20:19:04 UTC

Yes, this has been fixed. Also, I didn't know the KDE macro for kio, so I put just kio in there to make it compile ;)