Bug 264184

Summary: png-1.5 compatibility fix
Product: [Applications] digikam Reporter: Thomas Klausner <tk>
Component: Plugin-Bqm-ConvertAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: andrew.i.coles, caulier.gilles
Priority: NOR    
Version: 1.8.0   
Target Milestone: ---   
Platform: NetBSD pkgsrc   
OS: All   
Latest Commit: Version Fixed In: 1.9.0
Sentry Crash Report:
Attachments: Patch fixing the problem.

Description Thomas Klausner 2011-01-24 17:07:22 UTC 
Created attachment 56385 [details]
Patch fixing the problem.

In png-1.5, the prototype for png_set_iCCCP changed. The fifth argument was a
png_charp and is now a png_bytep. This breaks compilation, similar to
https://bugs.kde.org/show_bug.cgi?id=264181
This problem still exists in SVN trunk from a few minutes ago.

I've attached a patch for kipi-plugins-1.6.0 that fixes the problem with 1.5.0.
It probably needs changes to still work against older versions (which I don't
have installed).
Comment 1 Thomas Klausner 2011-01-24 23:56:23 UTC 
Andrew Coles fixed a similar problem for digikam in https://bugs.kde.org/show_bug.cgi?id=264181 modifying my patch so that it works with png-1.4 as well.
Comment 2 caulier.gilles 2011-01-25 07:36:38 UTC 
Andrew,

Can you manage this file too about libpng 1.5 issue, at the same time than #264181 ?

Thanks in advance

Gilles Caulier
Comment 3 Andrew Coles 2011-01-25 11:26:25 UTC 
SVN commit 1216971 by coles:

Added support for libpng 1.5.  As there's only one place in the file affected
by the API change, it's done with an #if at the point where it's needed.

BUG: 264184



 M  +8 -0      kpwriteimage.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1216971