| Summary: | [PATCH] K3b small fixes for windows build | ||
|---|---|---|---|
| Product: | [Applications] k3b | Reporter: | Andrius <andriusmao> |
| Component: | general | Assignee: | Michał Małek <michalm> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | kde-windows, trueg |
| Priority: | NOR | Keywords: | regression |
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | patch for windows build | ||
Hi, Your patch lists files with no changes e.g.: diff --git a/libk3b/CMakeLists.txt b/libk3b/CMakeLists.txt diff --git a/libk3b/tools/k3bcdparanoialib.h b/libk3b/tools/k3bcdparanoialib.h diff --git a/libk3b/tools/qprocess/k3bqprocess.cpp b/libk3b/tools/qprocess/k3bqprocess.cpp That's why ReviewBoard haven't accepted it. Please remove these lines and resubmit it on git.reviewboard.kde.org so we could discuss the patch in details. Thanks! Review request opened: http://git.reviewboard.kde.org/r/100457/ Thanks! |
Created attachment 56353 [details] patch for windows build Version: git (using Devel) OS: MS Windows Somehow git reviewboard does not let me upload this patch, please review. Those are some small fixes for building K3b under Windows, tested under MSVC 2008 only Reproducible: Always Steps to Reproduce: n/a. Actual Results: n/a. Expected Results: n/a. n/a.