| Summary: | The widget to select names is not large enough | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Julien Narboux <Julien> |
| Component: | Faces-Workflow | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 2.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52 | Version Fixed In: | 4.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
The widget width is too small
Debug statements tagging widget too small |
||
|
Description
Julien Narboux
2011-01-05 11:41:55 UTC
In preview view or icon view? Width or height is not enough? In preview view the width is not enough. Julien Git commit 13c21397e857463a64dea631045ae57cbbbca7dd by Marcel Wiesweg. Committed on 05/02/11 at 23:50. Pushed by mwiesweg into branch 'development/2.0'. Shorten the text from "Create new tag <...>" to "Create <...>", to avoid cutting the tag name CCBUG: 262175 M +2 -2 digikam/addtagscompletionbox.cpp http://commits.kde.org/digikam/13c21397e857463a64dea631045ae57cbbbca7dd Created attachment 59126 [details]
The widget width is too small
The width using current git trunk is still too small, i can only see the word "Create". Julien Created attachment 59280 [details]
Debug statements
There is code to calculate the needed width from the contents in the combobox. For me, the box usually exceeds the width of the line edit. In your screenshot it ends at about 50%.
The attached patch could give some information about what may be wrong. The output is produced when you type a letter in the line edit and autocompletion begins.
Julien, Do you take a look about marcel patch to progress in investiguations ? Gilles Caulier Julien Do you see my comment #7 ? Gilles Caulier This bug is still valid, the widget is too small, the problem for me is the height of the line edit field,I need magnifying glasses to see it :-) I know the widget is painted over the delegate, so this might not work, but couldn't this widget be wider than the thumbanil? The problem is that if you define an even smaller thumbnail size, it is not visible at all. Created attachment 67122 [details]
tagging widget too small
See how the height is kept properly even at minimal thumbnail size on my system: http://wstaw.org/m/2011/12/26/plasma-desktopWp1762.jpg Why does it work here and not for you? Marcel, This depend of widget style used with digiKam. Under MACOSX, It's a nightmare with Qt mac widget style. Go to Setup/Misc/Widget Style, and try with another one... Gilles Caulier Ok, I got it: I have switched on to display quite a few items below the picture. If I switch off everything, no widget is visible at all... Apparently, the placement and size adjustment of the overlay can be improved. This also applies to the grouping icon which you mentioned in another bug report. This opens a whole lot of problems to consider. Git commit 0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52 by Gilles Caulier. Committed on 15/07/2014 at 07:46. Pushed by cgilles into branch 'master'. Do not use a Qwidget as container of AssignNameWidget. This break layout with non Oxgen widget style (fully reproducible under OSX) Set argin a spacing to 1 pixel into AssignNameWidget layout. constify and polish implementations FIXED-IN: 4.2.0 M +41 -39 digikam/items/assignnameoverlay.cpp M +16 -15 digikam/items/assignnameoverlay.h M +3 -1 utilities/facemanagement/assignnamewidget.cpp http://commits.kde.org/digikam/0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52 |
