Bug 261957

I put together a simpler version of the code:

http://git.reviewboard.kde.org/r/100574/

It does not remember the column widths, but instead tries to ensure all columns get usable default widths: all columns but title are resized to fit their content, the title column gets the remaining width. The title column can still be resized if need be.

Created attachment 56889 [details]
article list issue

With this patch applied, I get a few more issues.

See the screenshot attached. With the default window size this is what I get for feeds with unusually long names.

Created attachment 56890 [details]
another screenshot

Another screenshot with a slightly shorter feed name.

Created attachment 56891 [details]
Usability issue

The auto adjusting also introduces a usability issue, Note author column size. Resizing the column is possible but akregator will auto-adjust it again the next time this feed is selected.

Created attachment 56894 [details]
Date column issue

Last issue noticed: When there is no vertical scrollbar, there's an empty area.

This issue still exists in 4.7.3

Created attachment 71211 [details]
Fix for bug, or workaround.

I wrote this patch. It's seems to fix this strange behavior. 

This behaviour caused:
header()->setStretchLastSection( false );
But the line is needed for correct positioning of the columns.

Following lines were removed because it set date column size in this path to one pixel:
header()->resizeSection( header()->logicalIndex( header()->count() - 1 ), 1 );

Tested on Kubuntu 12.04 with kde 4.8.3 and kdepim 4.8.3

Yashin,

I applied your patch.  but now I don't see the Date column at all, except on the feed group lists.

what did I miss?

(In reply to comment #8)
> Yashin,
> 
> I applied your patch.  but now I don't see the Date column at all, except on
> the feed group lists.
> 
> what did I miss?

Hi, Allen

I get similar behavior during debugging, when present in the functions ArticleListView::setFeedMode() ArticleListView::setGroupMode() of the next line.
header()->resizeSection( header()->logicalIndex( header()->count() - 1 ), 1 );
In fact, there is a column with a date, but its width is equal to one pixel.

Patched functions must be like this:

void ArticleListView::setGroupMode()
{
    if ( m_columnMode == GroupMode )
        return;

    if ( model() )
        m_feedHeaderState = header()->saveState();
    m_columnMode = GroupMode;
    restoreHeaderState();
}

void ArticleListView::setFeedMode()
{
    if ( m_columnMode == FeedMode )
        return;

    if ( model() )
        m_groupHeaderState = header()->saveState();
    m_columnMode = FeedMode;
    restoreHeaderState();
}

I also removed ArticleListFeedHeaders and ArticleListGroupHeaders from ~/.kde/share/config/akregatorrc

Created attachment 71326 [details]
fix with saved data upgrade support

I think the disappearance of a date column influenced the data stored in the unpatched version. I added an additional check on the width of the column with the date.

Or you can change the name for the stored data headers (ArticleListFeedHeaders and ArticleListGroupHeaders) in akregatorrc. This will not worry about the compatibility of software with this bug.

Git commit 9345245335b5341bff9de06778652338006fc405 by Allen Winter.
Committed on 25/05/2012 at 18:32.
Pushed by winterz into branch 'master'.

Fix the last column width problems.
Yashin, thanks for your work on this.

Not resolving the bug yet since we may still want to save/restore
column widths. But this patch does improve things.
MERGE: 4.8

M  +3    -10   akregator/src/articlelistview.cpp

http://commits.kde.org/kdepim/9345245335b5341bff9de06778652338006fc405

Git commit 167f33cf7642b798b72f743c633b06f5fc343aba by Allen Winter.
Committed on 25/05/2012 at 18:32.
Pushed by winterz into branch 'KDE/4.8'.

Fix the last column width problems.
Yashin, thanks for your work on this.

Not resolving the bug yet since we may still want to save/restore
column widths. But this patch does improve things.
MERGE: 4.8
(cherry picked from commit 9345245335b5341bff9de06778652338006fc405)

M  +3    -10   akregator/src/articlelistview.cpp

http://commits.kde.org/kdepim/167f33cf7642b798b72f743c633b06f5fc343aba

This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of akregator (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.

Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.