Summary: | "create new" is always graid out in columns view | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Jim Jones <rauchwolke> |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | frank78ac, the.warl0ck.1989 |
Priority: | NOR | ||
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.6.0 | |
Sentry Crash Report: | |||
Attachments: | picture showing the bug |
Description
Jim Jones
2010-12-02 02:56:54 UTC
when i switch to the detail view and back to column view it works as expected .... but when dolphin starts in column view it doesnt work .... Thanks for the bug report! I could not reproduce the bug in trunk. What I did: 1. Open Dolphin -> shows the home folder in Details View for me. 2. Switch to Columns View and close Dolphin. 3. Open Dolphin again -> shows the home folder in Columns View. 4. Right-click the empty space in the column -> "Create New..." is enabled. If different (or more) steps are required to reproduce the issue, please let us know. Thanks. this also works for me as long i dont use the sidebar to get to an stored folder . after using it, going from /home to /mnt/data for example, "Create New" is always graid out ... i marked the sidebar with a arrow to show you what i mean in the attached picture ... Created attachment 53976 [details]
picture showing the bug
Thanks, I could reproduce that now in trunk. Another way to reproduce: run "dolphin ~" when the home folder defaults to Columns View. Just for the record, I can also reproduce this in 4.4.4 and in the 4.5 branch, so it seems it's not a recent regression. *** Bug 259498 has been marked as a duplicate of this bug. *** Other ways to reproduce: 1. Open Dolphin, click "Root" in Places Panel, click "tmp" directory -> /tmp is opened in 2nd column, but "Create New..." is disabled. or 2. Call "dolphin /tmp" from Konsole -> "Create New..." is also disabled. On the other hand, opening Dolphin and entering "/tmp" in the location bar works as expected - the menu is enabled. i updated dolphin to the latest svn commit (1205345) - with this version "create new" works - now "create new" is never graid out even not in folders where i have no write permission like in / i thing the bug can be closed .... I can confirm that. But I don't think we should close this - the behaviour is still buggy. And I think the relevant code hasn't actually changed much today. I can't explain why the behaviour changed though. SVN commit 1206749 by ppenz: Fix issue that the enabled state of the "Create New..." menu is not updated correctly in the column-view. BUG: 258534 FIXED-IN: 4.6.0 M +2 -28 dolphinviewcontainer.cpp M +0 -2 dolphinviewcontainer.h M +66 -28 views/dolphinview.cpp M +23 -0 views/dolphinview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1206749 @Frank: The root cause of this issue was that only the root-directory-lister has been considered to determine the writestate. But this does not work in the column-view, as the directory lister changes with each column... For 4.7 I plan to encapsulate all the directory lister things inside DolphinView and the DolphinViewContainer will have no knowledge about this anymore. It is quite a trivial change in the meantime, but I don't like to do such a change shortly before the release as it is too risky. @Peter: That sounds good :-) |