| Summary: | icon size in pager tooltip should follow small icons settings | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Janet <bugzilla> |
| Component: | widget-pager | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | laidig, sreich |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8 | |
| Sentry Crash Report: | |||
|
Description
Janet
2010-11-23 05:47:35 UTC
Git commit f95e3bad93b0a3efe5c6d2f0dd92cacb22f0ca31 by Shaun Reich. Committed on 29/12/2011 at 06:33. Pushed by sreich into branch 'master'. Prefer KIconLoader::Small icon sizes for window thumbnails when possible This makes the pager actually abide by the system settings designated Small icon size. So increasing it to e.g. 42x42 would make the window icons in the pager use that size. It's set to use the width/height (whichever is smallest), and the KIconLoader::Small. Whichever value is smaller. Was previously hardcoded to 16x16. Should be a safe change, going to backport. M +11 -6 plasma/desktop/applets/pager/pager.cpp http://commits.kde.org/kde-workspace/f95e3bad93b0a3efe5c6d2f0dd92cacb22f0ca31 Git commit f9db201ebb1b52c71fad13c6497302617e54b015 by Shaun Reich. Committed on 29/12/2011 at 06:33. Pushed by sreich into branch 'KDE/4.8'. Prefer KIconLoader::Small icon sizes for window thumbnails when possible This makes the pager actually abide by the system settings designated Small icon size. So increasing it to e.g. 42x42 would make the window icons in the pager use that size. It's set to use the width/height (whichever is smallest), and the KIconLoader::Small. Whichever value is smaller. Was previously hardcoded to 16x16. Should be a safe change, going to backport. (cherry picked from commit 30366dfdcb6e649aca7edcf8fb9ea1b4a8fa3aa7) M +11 -6 plasma/desktop/applets/pager/pager.cpp http://commits.kde.org/kde-workspace/f9db201ebb1b52c71fad13c6497302617e54b015 By the way, let me know if this change is optimal or if you need some further tweaking of it... Git commit 1f5bf6e3fb8646fa3b768d88ebb2c5e8178b517e by Shaun Reich. Committed on 29/12/2011 at 20:14. Pushed by sreich into branch 'KDE/4.8'. Use KIconLoader::Small for tooltip thumbnails as well. It's possible ::Small should not be used for the tooltips of the pager, perhaps ::Panel or ::Toolbar, etc. etc.? This should present no change to anyone, since the defaults for ::Small is 16x16 anyways. FIXED-IN: 4.8 (cherry picked from commit e4736084dd391d3acd48e1bd64adbd5760eca68c) M +4 -2 plasma/desktop/applets/pager/pager.cpp http://commits.kde.org/kde-workspace/1f5bf6e3fb8646fa3b768d88ebb2c5e8178b517e Git commit e4736084dd391d3acd48e1bd64adbd5760eca68c by Shaun Reich. Committed on 29/12/2011 at 20:14. Pushed by sreich into branch 'master'. Use KIconLoader::Small for tooltip thumbnails as well. It's possible ::Small should not be used for the tooltips of the pager, perhaps ::Panel or ::Toolbar, etc. etc.? This should present no change to anyone, since the defaults for ::Small is 16x16 anyways. FIXED-IN: 4.8 M +4 -2 plasma/desktop/applets/pager/pager.cpp http://commits.kde.org/kde-workspace/e4736084dd391d3acd48e1bd64adbd5760eca68c Thanks :) |