| Summary: | Amarok Crashes (often) when switching to Podcast View [@ PlaylistBrowserNS::PlaylistBrowserView::viewportEvent] | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | dylan.e.carter |
| Component: | Podcast | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | crash | CC: | anatomy.nut, andresbajotierra, bart.cerneels, dinizdiogo, dominique195, valorie.zimmerman |
| Priority: | NOR | ||
| Version: | 2.3.2 | ||
| Target Milestone: | 2.4.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
||
|
Description
dylan.e.carter
2010-11-19 21:18:00 UTC
Sorry, but your backtrace is not useful, as you are lacking debugging symbols. If you can reproduce this bug, please check here on how to get a valid backtrace: http://techbase.kde.org/Development/Tutorials/Debugging/How_to_create_useful_crash_reports Created attachment 53677 [details]
New crash information added by DrKonqi
amarok (2.4-GIT) on KDE Platform 4.5.3 (KDE 4.5.3) using Qt 4.7.0
- What I was doing when the application crashed: Had just played to the end of an album in the playlist, and was going to get the next podcast in a series. As soon as I selected Podcasts from the menu, instant crash.
Freshly built Amarok from GIT an hour or so ago, Xine backend, Kubuntu 10.10, KDE 4.5.3
-- Backtrace (Reduced):
#6 QModelIndex (this=0x29c8e10, child=...) at ../../include/QtCore/../../src/corelib/kernel/qabstractitemmodel.h:65
#7 QSortFilterProxyModel::parent (this=0x29c8e10, child=...) at itemviews/qsortfilterproxymodel.cpp:1656
#8 0x00007f35534f4251 in parent (this=0x2b56790, index=<value optimized out>) at ../../include/QtCore/../../src/corelib/kernel/qabstractitemmodel.h:389
#9 QTreeView::indexRowSizeHint (this=0x2b56790, index=<value optimized out>) at itemviews/qtreeview.cpp:2758
#10 0x00007f35534f49ac in QTreeViewPrivate::itemHeight (this=0x2b568a0, item=7) at itemviews/qtreeview.cpp:3229
Thank you for the feedback. *** Bug 259301 has been marked as a duplicate of this bug. *** commit ec2f04a8dce4ac12e181d494f4049ce94cd1ca94 branch master Author: Bart Cerneels <bart.cerneels@kde.org> Date: Sun Dec 12 20:58:51 2010 +0100 Fix mistakes in Qt itemmodels & proxy. Possible fix for some crashes that happen in release builds only. CCBUG:257353 CCBUG:257330 diff --git a/src/browsers/playlistbrowser/PlaylistBrowserModel.cpp b/src/browsers/playlistbrowser/PlaylistBrowserModel.cpp index 2e74b82..a0f8076 100644 --- a/src/browsers/playlistbrowser/PlaylistBrowserModel.cpp +++ b/src/browsers/playlistbrowser/PlaylistBrowserModel.cpp @@ -591,15 +591,11 @@ PlaylistBrowserModel::slotPlaylistAdded( Playlists::PlaylistPtr playlist, int ca for( i = 0; i < m_playlists.count(); i++ ) { if( lessThanPlaylistTitles( playlist, m_playlists[i] ) ) - { - m_playlists.insert( i, playlist ); break; - } } - if( i == m_playlists.count() ) - m_playlists.append( playlist ); beginInsertRows( QModelIndex(), i, i ); + m_playlists.insert( i, playlist ); endInsertRows(); } diff --git a/src/browsers/playlistbrowser/QtGroupingProxy.cpp b/src/browsers/playlistbrowser/QtGroupingProxy.cpp index d4c8822..b66386f 100644 --- a/src/browsers/playlistbrowser/QtGroupingProxy.cpp +++ b/src/browsers/playlistbrowser/QtGroupingProxy.cpp @@ -119,7 +119,7 @@ QtGroupingProxy::buildTree() if( !m_model ) return; - emit layoutAboutToBeChanged(); + beginResetModel(); m_groupHash.clear(); //don't clear the data maps since most of it will probably be needed again. @@ -153,7 +153,7 @@ QtGroupingProxy::buildTree() } // dumpGroups(); - emit layoutChanged(); + endResetModel(); } QList<int> [Comment from a bug triager] As described in bug 219964 comment 13, this may be a bug in the Qt library which should be fixed soon. Regards *** Bug 264166 has been marked as a duplicate of this bug. *** Created attachment 57169 [details]
New crash information added by DrKonqi
amarok (2.3.2) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0
- What I was doing when the application crashed: Amarok crashes when I transfer my 8GB playlist.
-- Backtrace (Reduced):
#7 QModelIndex (this=0x99e6448, child=...) at ../../include/QtCore/../../src/corelib/kernel/qabstractitemmodel.h:65
#8 QSortFilterProxyModel::parent (this=0x99e6448, child=...) at itemviews/qsortfilterproxymodel.cpp:1656
#9 0xb66cc942 in parent (this=0x99e8778, index=...) at ../../include/QtCore/../../src/corelib/kernel/qabstractitemmodel.h:389
#10 QTreeView::indexRowSizeHint (this=0x99e8778, index=...) at itemviews/qtreeview.cpp:2758
#11 0xb66cd16b in QTreeViewPrivate::itemHeight (this=0x99e6a20, item=0) at itemviews/qtreeview.cpp:3229
As described at https://bugs.kde.org/show_bug.cgi?id=219964#c26 the bug in Qt is fixed for 4.7.3 (In reply to comment #9) > As described at https://bugs.kde.org/show_bug.cgi?id=219964#c26 the bug in Qt > is fixed for 4.7.3 Which doesn't really help for this report, as Amarok depends on Qt 4.6 at least for another few . versions round, largely depending on the avilability of Qt 4.7 in the distributions. A solution would be to backport the fix to Qt 4.6.x or if all distribution patch their versions. This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. NVM, closing this as upstream. |