| Summary: | Partition Manager fails to see /dev/mmcblk0 | ||
|---|---|---|---|
| Product: | [Applications] partitionmanager | Reporter: | Andrew M <quantumphazor> |
| Component: | general | Assignee: | Volker Lanz <vl> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alpeterson, andrius, byczech, fabo, illumilore, nowardev, rootkit85 |
| Priority: | NOR | ||
| Version: | 1.0.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
add mmcblk devices to the devices list
add mmcblk devices to the devices list |
||
|
Description
Andrew M
2010-11-15 11:21:04 UTC
Also in Kubuntu 11.04, very tough for me to create a dos boot disk to flash my firmware. bug is confirmed. Confirmed
seems that the bug lies in scanDevices() in src/core/libparted.cpp:
QFile partitions("/proc/partitions");
if (partitions.open(QIODevice::ReadOnly))
{
QRegExp rxLine("\\s*(\\d+)\\s+(\\d+)\\s+(\\d+)\\s([^0-9]+)\\s+");
that regular expression gets the list of the partitions and remove the trailing numbers, so /dev/mmcblk0 becames /dev/mmcblk which isn't a valid device name
*** Bug 291008 has been marked as a duplicate of this bug. *** Created attachment 73712 [details]
add mmcblk devices to the devices list
I just got up and maybe I'm not yet at the top of my code-reading-abilities, but would this regex cover devices with two-digit-numbers, e.g. mmcblk23? Sure, do you have more than 10 MMC card reader? (In reply to comment #6) > I just got up and maybe I'm not yet at the top of my code-reading-abilities, > but would this regex cover devices with two-digit-numbers, e.g. mmcblk23? Is that some kind of "640kb ought to be enough" trick question? ;-) What's wrong with fixing the regex? Created attachment 73722 [details]
add mmcblk devices to the devices list
*** Bug 311194 has been marked as a duplicate of this bug. *** SVN commit 1327786 by stikonas: Fix detection of memory cards. M +4 -2 plugins/libparted/libpartedbackend.cpp M +1 -1 util/helpers.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1327786 Partition Manager does not number partitions on memory card correctly. Devices are numbered /dev/mmcblk0 but partitions are numbered /dev/mmcblk0p1. Partitionmanager fails to add 'p' before partition number. SVN commit 1337488 by stikonas: Fix detection of partitions' paths. Previously, partition number was added to device path. However, there are devices with more complicated numbering scheme, e.g. memory cards may have /dev/mmcblk0p1. It seems that the easiest way to handle this is to use partition path instead of device path + partition number . M +1 -1 backend/corebackendpartitiontable.h M +23 -10 core/partition.cpp M +6 -2 core/partition.h M +1 -1 core/partitiontable.cpp M +1 -1 gui/infopane.cpp M +1 -1 gui/mainwindow.cpp M +3 -3 jobs/createpartitionjob.cpp M +2 -2 ops/copyoperation.cpp M +1 -1 ops/newoperation.cpp M +2 -2 ops/restoreoperation.cpp M +2 -2 plugins/dummy/dummypartitiontable.cpp M +1 -1 plugins/dummy/dummypartitiontable.h M +2 -2 plugins/libparted/libpartedbackend.cpp M +6 -6 plugins/libparted/libpartedpartitiontable.cpp M +1 -1 plugins/libparted/libpartedpartitiontable.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1337488 *** Bug 316056 has been marked as a duplicate of this bug. *** |