| Summary: | Selecting Podcast view crashes Amarok; ditto for Saved Playlist [@ PlaylistBrowserNS::PlaylistBrowserView::viewportEvent] | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Valorie Zimmerman <valorie.zimmerman> |
| Component: | Podcast | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | 20120808_bugs.kde.org, bart.cerneels, karl, memnek, shaddowy2 |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | 2.5.0 | ||
| Target Milestone: | 2.6 | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/afaf42eb065074ed4c0b023e602f4e08f63c4d43 | Version Fixed In: | 2.6 |
| Sentry Crash Report: | |||
|
Description
Valorie Zimmerman
2010-11-14 06:38:59 UTC
Confirmed. It sadly is not reproducible every time, I already filed this as bug 252622 and closed it since it works most of the time for me. Oddly enough I haven't had another crash like this since I filed the bug. I don't know if updates fixed it, or chance, or what, but those two crashes within the hour were the last. Closing as fixed for now, feel free to reopen if you can reproduce this crash. *** Bug 262550 has been marked as a duplicate of this bug. *** *** Bug 262652 has been marked as a duplicate of this bug. *** *** Bug 293558 has been marked as a duplicate of this bug. *** Reopening based on duplicate bug 293558 *** Bug 299649 has been marked as a duplicate of this bug. *** Git commit e4c09dd3d207e7de4c9db2cd382746f98764c0dd by Bart Cerneels. Committed on 05/06/2012 at 14:54. Pushed by shanachie into branch 'master'. Apply update from QtGroupingProxy. commit 42febf5 from https://gitorious.org/qtgroupingproxy/qtgroupingproxy Call endRemoveRows in reverse order as begin... This is a hack, because beginRemoveRows() should always be followed by endRemoveRows() before the next remove. But since QAbstractItemView uses a stack to apply changes it works with those. Might break proxyies though. Possible fix for SortFilterProxy crashes. Related: bug 300977 FIXED-IN:2.6 M +40 -16 src/browsers/playlistbrowser/QtGroupingProxy.cpp http://commits.kde.org/amarok/e4c09dd3d207e7de4c9db2cd382746f98764c0dd Git commit afaf42eb065074ed4c0b023e602f4e08f63c4d43 by Bart Cerneels. Committed on 05/06/2012 at 14:54. Pushed by shanachie into branch 'master'. Apply update from QtGroupingProxy. commit 42febf5 from https://gitorious.org/qtgroupingproxy/qtgroupingproxy Call endRemoveRows in reverse order as begin... This is a hack, because beginRemoveRows() should always be followed by endRemoveRows() before the next remove. But since QAbstractItemView uses a stack to apply changes it works with those. Might break proxyies though. Fixes QVector crash in QSortFilterProxyModel with Qt debug builds. Related: bug 300977 FIXED-IN:2.6 M +3 -2 src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp M +1 -5 src/browsers/playlistbrowser/PlaylistBrowserModel.cpp M +13 -2 src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp M +1 -0 src/browsers/playlistbrowser/PlaylistsByProviderProxy.h M +2 -2 src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp M +91 -44 src/browsers/playlistbrowser/QtGroupingProxy.cpp M +14 -11 src/browsers/playlistbrowser/QtGroupingProxy.h http://commits.kde.org/amarok/afaf42eb065074ed4c0b023e602f4e08f63c4d43 Closing, feel free to reopen if it is still reproducible in current git. |