| Summary: | Build with Non-colocated Source and Build Directories Fails | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Grant Erickson <gerickson> |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | mark, peter.maydell |
| Priority: | NOR | ||
| Version First Reported In: | 3.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | This patch fixes the fact that valgrind default suppression files are not conditioned based on whether they exist in the source directory or whether they are created anew in the build directory. | ||
NB that this is the first of the two issues noted in bug 232510 as preventing 'make distcheck' from working. Sorry, I missed this bug earlier. Although this bug is older, the newer bug #333628 has a bit more details. *** This bug has been marked as a duplicate of bug 333628 *** |
Created attachment 53170 [details] This patch fixes the fact that valgrind default suppression files are not conditioned based on whether they exist in the source directory or whether they are created anew in the build directory. Version: 3.6.0 OS: Linux When building valgrind-3.6.0 under ARM/Linux with non-colocated source and build directories, the build fails because the top-level generated make file cannot find most of the suppression files. Reproducible: Always Steps to Reproduce: 1. Unarchive the valgrind-3.6.0 archive. 2. Create a directory at the same level as the resulting valgrind-3.6.0 directory, called "build". 3. Change to the directory "build" 4. Run ../valgrind-3.6.0/configure 5. Type 'make' to begin the build. Actual Results: The step where it runs 'cat $(DEFAULT_SUPP_FILES) >> default.supp fails with 'xfree-3.supp': No such file or directory", etc. Expected Results: Each of these suppression files needs to be qualified or search for in both the source or build directory prior to cat'ing them. The attached patch addresses the issue.