Bug 251367

Summary:	'ServerSide subscription' dialogue scrolling zone too small
Product:	[Frameworks and Libraries] Akonadi	Reporter:	Sabine Faure <sabine>
Component:	IMAP resource	Assignee:	Kevin Ottens <ervin>
Status:	CLOSED FIXED
Severity:	normal	CC:	felix.wolfsteller, kdepim-bugs, vkrause
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Maemo 5
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Scrolling zone too small for the user to check a folder

Description Sabine Faure 2010-09-15 20:23:57 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Impossible to select a shared folder to subscribe too since the scrolling zone for displaying the folders name is way to small for the user to read even one folder name fully.

Reproducible: Always

Steps to Reproduce:
- Launch Kmail-mobile
- Click on your Imap account
- Open the 'Actions' tab
- Click on 'Account'
- Click on 'Edit account'
- Check the ' Enable Server-Side Subscriptions' check box
- Click on 'Serverside Subscription...' button
- Try to select a shared folder from the list to subscribe to


Actual Results:  
It is impossible to subscribe to any folder because the user cannot browse the folder names list.

Even if the user knows the folder name and uses the search field he cannot scroll down to check the folder name to subscribe to it.

Expected Results:  
The scrolling zone should be wide enough for the user to select on folder at least without having to scroll down.

N900, 4:4.5~20100914.1175313-1maemo1.1174921

Comment 1 Sabine Faure 2010-09-15 20:25:56 UTC

Created attachment 51696 [details]
Scrolling zone too small for the user to check a folder

N900, 4:4.5~20100914.1175313-1maemo1.1174921

Comment 2 Kevin Ottens 2010-09-21 09:40:15 UTC

SVN commit 1177766 by ervin:

Provide a new much simpler SubscriptionDialog. It actually comes in two
flavors depending on the build type. The desktop flavor provides a tree view
and filter widgets, while the mobile flavor provides only a flattened
list.

As a consequence:
 - We don't depend on QTreeView in the mobile case.
 - We don't depend on kdepim-copy anymore.

Used the opportunity to add a small test app for the subscription dialog
itself.

BUG: 251367


 M  +1 -1      CMakeLists.txt  
 M  +1 -1      imapaccount.cpp  
 M  +2 -2      imapaccount.h  
 M  +4 -5      setupserver.cpp  
 M  +234 -320  subscriptiondialog.cpp  
 M  +64 -166   subscriptiondialog.h  
 M  +11 -0     tests/CMakeLists.txt  
 A             tests/testsubscriptiondialog.cpp   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=1177766

Comment 3 Felix Wolfsteller 2010-09-21 10:05:03 UTC

It stays "Loading..." for me in version 4:4.5~20100920.1177660-1maemo1.1177547 .

Other than that dialog looks really similar to the pasted screenshot.

Note that my test-account is not a fully-fledged kolab-account ( https://bugs.kde.org/show_bug.cgi?id=251823 ?).

Comment 4 Kevin Ottens 2010-09-21 10:31:11 UTC

As the commit message implied you need r1177766 or later to test the fix. From your comment you tested using an older revision.

Comment 5 Felix Wolfsteller 2010-09-21 10:56:37 UTC

doh, sorry - I supposed your comment was much older. Will test with later versions soon and close if found fixed.

Comment 6 Sabine Faure 2010-09-23 12:35:41 UTC

It is corrected now.

The dialogue has been completely remodeled and now it is easy to select a folder name by just scrolling down the list.

N900, 4:4.5~20100922.1178352-1maemo1.1177763

Comment 7 Sabine Faure 2010-12-24 00:30:09 UTC

I retested this today and it still works fine so I am closing this bug.

N900, 4:4.6~.20101223.2034.git9cc0c3e-1maemo1.120883