Summary: | Konsole inverts $COLUMNS and $LINES when resized from vi | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Alain BAECKEROOT <alain.baeckeroot> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | adaptee, the_shark |
Priority: | NOR | Keywords: | testcase |
Version: | 2.3.2 | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | call setImageSize() with the right order of lines and columns parameter |
Description
Alain BAECKEROOT
2010-07-25 15:02:00 UTC
same problem in Konsole 2.4.5 using KDE 4.4.5 *** Bug 187875 has been marked as a duplicate of this bug. *** Created attachment 61923 [details]
call setImageSize() with the right order of lines and columns parameter
I can reproduce this with 2.7.999.
The cause of this problem is quite trival: one line within Vt102Emulation.cpp calls setImagesize() with the order of lines and columns parameter swapped. The attached patch simply make it use the right order.
However, it seems currently konsole does not support resizing from terminal process(vi, etc). The COLUMNS and LINES environment variables are updated, by the konsole window does not actually change its size .
Yes, thanks - I also have the patch around somewhere. I think I had tried to get the resizing to work (as it did once) and forgot about the col/row change. I'll get to it shortly. Git commit c252666b98b405a54f0551c5a6632daea29ad230 by Kurt Hindenburg. Committed on 19/07/2011 at 04:39. Pushed by hindenburg into branch 'master'. Fix $COLUMNS/$LINES after resizing. The 2 were inverted previously. CCBUG: 245746 M +1 -1 src/Vt102Emulation.cpp http://commits.kde.org/konsole/c252666b98b405a54f0551c5a6632daea29ad230 *** This bug has been marked as a duplicate of bug 238073 *** Git commit eb9691d3f6a324c1801531ff2d3960b3656665fb by Kurt Hindenburg. Committed on 19/07/2011 at 04:39. Pushed by hindenburg into branch 'KDE/4.7'. Fix $COLUMNS/$LINES after resizing. The 2 were inverted previously. CCBUG: 245746 (cherry picked from commit c252666b98b405a54f0551c5a6632daea29ad230) M +1 -1 src/Vt102Emulation.cpp http://commits.kde.org/konsole/eb9691d3f6a324c1801531ff2d3960b3656665fb |