Summary: | Error in WhatsThisHelp of Tag Guesser Configuration dialog (no button called Suggest in the gui) | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Burkhard Lück <lueck> |
Component: | general | Assignee: | Scott Wheeler <wheeler> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jangerrit, mpyne, rakuco |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.7.1 | |
Sentry Crash Report: |
Description
Burkhard Lück
2010-07-23 13:23:45 UTC
This seems to have been the case since 2003... r214220 added the "Suggest" button, r216312 removed it from the code. Right now, I'd replace "Suggest button" with "Guess Tag Information from File Name menu option" (or something like that) in the text. Burkhard, can we still do that in time for 4.7 or should we wait for the string freeze to be lifted and aim at 4.8? (In reply to comment #1) > > Burkhard, can we still do that in time for 4.7 or should we wait for the > string freeze to be lifted and aim at 4.8? Please wait until 4.7.0 is out (we have to take care for the small translation teams fighting hard to meet the translation release critera to get included), then commit to master, ask for approval on kde-i18n-doc@kde.org (no doubt you'll get it) and backport for 4.7.1. Thanks for taking care of this SVN commit 1246190 by jangmarker: Correct WhatsThisToolip's text of the guesser configuration dialog to reflect the UI. CCBUG: 245533 M +1 -1 tagguesserconfigdlgwidget.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=1246190 Jan, Please don't forget to commit this to the 4.7 branch as well and mail the i18n team as described. Okay, I sent an e-mail to the mailinglist and asked for approval. If I get it I'll commit the patch and close this bug report. Thanks for pointing it out. bug is fixed in trunk+4.7, but still not resolved. Any reason or just an oversight? I didn't fix it in the 4.7 branch and I don't see a commit which fixes it. I'd commit the fix to the 4.7 branch but the only answer I got from the i18n mailing list is from the German team. You overlooked the OK from DA + HU see http://lists.kde.org/?l=kde-i18n-doc&m=131299019010001&w=2 and you did not get a NO. So you are allowed to break the string freeze, please commit asap. Thanks SVN commit 1248724 by jangmarker: Backporting commit r1246190. Correct WhatsThisToolTip's text of the guesser configuration dialog to reflect the UI. BUG: 245533 Fixed-In: 4.7.1 M +1 -1 tagguesserconfigdlgwidget.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=1248724 Thank you, Burkhard for pushing me. The fix is in the 4.7 branch. Sorry that I overlooked the emails, sometimes my spamfilter filters them. |