Bug 243160

Summary:	Check that destination has enough space before preparing move/copy job
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Erik Esterer <erik.esterer>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugseforuns, der.stefon, frank78ac, hans.bergles, kdelibs-bugs, nate, shafff, yabolus
Priority:	NOR	Keywords:	junior-jobs, usability
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/5a48bd21212c1429cce1f95f9f0a7871d41f41c2	Version Fixed In:	5.51
Sentry Crash Report:

Description Erik Esterer 2010-06-29 14:38:55 UTC

Version:           4.4 (using KDE 4.4.4) 
OS:                Linux

If you copy one file to a flash memory - file size has to be bigger than free space on flash memory - it starts copying the file and aborts only after the free space is filled up.
It might be useful to start copying if you copy many files, but it's quite useless for only one file. Since the available free space on flash memory is already shown in various places, it is definitely known.
It tested this with USB flash drives and memory cards.

Reproducible: Always

Steps to Reproduce:
1. Plug in a flash memory and mount it
2. Choose one file with size bigger than the free space on that flash memory and copy it

Actual Results:  
KIO starts copying the file and stops when the flash memory got no more free space. You get notified and the unfinished file will be removed.

Expected Results:  
Compare the free space of the USB flash drive with the file size, if file size > free space: don't copy

Comment 1 Stefan Esterer 2010-07-09 18:16:17 UTC

Can confirm the bug in debian testing/Squeeze with kde 4.4.4 ...

Comment 2 Frank Reininghaus 2010-12-04 01:30:50 UTC

*** Bug 245229 has been marked as a duplicate of this bug. ***

Comment 3 Frank Reininghaus 2010-12-04 01:30:58 UTC

*** Bug 258730 has been marked as a duplicate of this bug. ***

Comment 4 Johann Bergles 2010-12-04 09:50:21 UTC

*** This bug has been confirmed by popular vote. ***

Comment 5 Piotr Mitas 2010-12-04 10:48:49 UTC

It also would be nice if KDE checked whether the file size is <= 4 294 967 295 bytes if the target filesystem is FAT.

Comment 6 Johann Bergles 2011-03-17 09:15:55 UTC

Still in 4.6.1
Too bad :(
Maybe in 5.0 ?

Comment 7 Nick Shaforostoff 2011-03-25 13:58:54 UTC

i'd say, check any partition disregarding file count (at least, if it is known).

also if multiple files are copied, it could do the check in parallel.

there is also bug 194181 and bug 194806 plus bug 152760 regarding end of free space issue

Comment 8 Nick Shaforostoff 2011-12-12 13:09:07 UTC

ok, so if nobody objects, i'm changing title to reflect genericity of the bug report

Comment 9 Nick Shaforostoff 2011-12-14 14:57:05 UTC

https://git.reviewboard.kde.org/r/103412/

Comment 10 Nick Shaforostoff 2011-12-21 14:57:09 UTC

Git commit 50ccd8f037eb6c412260d49afcf8e5b9f1d8afa0 by Nick Shaforostoff.
Committed on 21/12/2011 at 15:51.
Pushed by shaforo into branch 'KDE/4.7'.

a very basic (with lots of TODOs for more advanced cases) fix for
CCBUG: 243160
which checks for free space before each filecopy process start
REVIEW: 103412

M  +45   -4    kio/kio/copyjob.cpp

http://commits.kde.org/kdelibs/50ccd8f037eb6c412260d49afcf8e5b9f1d8afa0

Comment 11 David Faure 2011-12-22 17:30:34 UTC

Git commit b46ba0f17c6a8081e7e961a92c1aa832cfba9c51 by David Faure.
Committed on 22/12/2011 at 19:32.
Pushed by dfaure into branch 'KDE/4.7'.

Fix erroneous "disk full" error when saving http downloads to disk.

This is because the size of the file is often unknown, therefore set to -1.
CCBUG: 243160

M  +5    -10   kio/kio/copyjob.cpp

http://commits.kde.org/kdelibs/b46ba0f17c6a8081e7e961a92c1aa832cfba9c51

Comment 12 Shubham 2018-09-17 04:34:50 UTC

Git commit 5a48bd21212c1429cce1f95f9f0a7871d41f41c2 by Shubham Jangra.
Committed on 17/09/2018 at 04:34.
Pushed by shubham into branch 'master'.

Warn user before copy/move operation if available space is not enough

Summary: BUG: 243160

Reviewers: pino, dfaure, broulik, ngraham

Reviewed By: ngraham

Subscribers: ngraham, dfaure, pino, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14757

M  +6    -1    src/core/copyjob.cpp

https://commits.kde.org/kio/5a48bd21212c1429cce1f95f9f0a7871d41f41c2