Bug 241049

Summary:	kwin 4.4.81: pack no longer working, producing huge windows which eat all ram
Product:	[Plasma] kwin	Reporter:	Christian (Fuchs) <kde>
Component:	general	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jimmy.kloss, piotr.budny+bugskde, rad.n, tendays-kde, vmatare+kdebug, w01dnick
Priority:	NOR
Version:	git master
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:	4.5.2
Sentry Crash Report:

Description Christian (Fuchs) 2010-06-07 22:37:01 UTC

Version:           SVN (using Devel) 
OS:                Linux

In KDE 4.4.81 the pack window left/right/up/down functionality is no longer working. It produces strange results, as an example 

xwininfo: Window id: 0x360004e "fuchs@thinkfox:~"

  Absolute upper-left X:  4
  Absolute upper-left Y:  305
  Relative upper-left X:  0
  Relative upper-left Y:  0
  Width: 65528
  Height: 65509
  Depth: 32
  Visual: 0x23
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x3600001 (not installed)
  Bit Gravity State: NorthWestGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: no
  Corners:  +4+305  --64092+305  --64092--64914  +4--64914
  -geometry 65528x65509+0-55


This is reproducible with all applications. I use the hotkeys to activate this. Desktop effects are enabled, but this doesn't seem to make a difference

Reproducible: Always

Steps to Reproduce:
Enable pack window to the left/right/up/down for any window with kwin 4.4.81

Actual Results:  
a huge window is produced on the outside of the desktop, eating almost all memory when desktop effects are enabled

Expected Results:  
the window is packed to the right/left/top/bottom 

gentoo, x86_64, KDE 4.4.81 from the KDE overlay

Comment 1 Christian (Fuchs) 2010-06-07 22:59:17 UTC

Sorry, I forgot to mention: 

I have a single screen setup, one 1440x900 Notebook TFT. 
The driver in use is the nvidia binary driver. 

Xorg is 1.8.1 and Qt is 4.7 (from Nokia trunk) 
Due to limited time (final exams) I can't do deep tests with different software versions, sorry. Hope you are able to reproduce it anyway. 

Kind regards, 

Christian

Comment 2 Martin Flöser 2010-06-10 21:47:10 UTC

I didn't know that this feature existed, but on special request I can confirm that it doesn't work.

Comment 3 Mykola Krachkovsky 2010-07-28 06:20:25 UTC

KWin 4.4.95 (RC3)
Window packing also didn't work. As for me pack to left/up/down simply makes nothing and to right (when it used first, not after left/up/down direction) - hides window and application 'eats' about 2GB of RAM (no more, though it can - I use x64 system with 4GB of RAM and 5GB swap).

Comment 4 Christoph Feck 2010-08-11 15:02:22 UTC

*** Bug 247366 has been marked as a duplicate of this bug. ***

Comment 5 Martin Flöser 2010-08-29 10:34:36 UTC

SVN commit 1169432 by graesslin:

Fix window movment regression (e.g. pack) in 4.5.

The regression was caused in tiling which set the geometry to a different one again.
Nikhil please verify that tiling is still working correctly. Looking at the code this
commit should be side-effect free. When coming from Client::move() moveResizeGeom and
initialMoveResizeGeom may not be set. So I think the code in notifyTilingWindowMove()
cannot work at all ;-)
CCMAIL: nsm.nikhil@gmail.com
BUG: 241049
FIXED-IN: 4.5.2



 M  +0 -1      tiling.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1169432

Comment 6 Martin Flöser 2010-08-29 10:36:28 UTC

SVN commit 1169433 by graesslin:

Forward port rev 1169432: Fix window movment regression (e.g. pack) in 4.5.

The regression was caused in tiling which set the geometry to a different one again.
Nikhil please verify that tiling is still working correctly. Looking at the code this
commit should be side-effect free. When coming from Client::move() moveResizeGeom and
initialMoveResizeGeom may not be set. So I think the code in notifyTilingWindowMove()
cannot work at all ;-)
CCBUG: 241049

 M  +0 -1      tiling.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1169433

Comment 7 Christian (Fuchs) 2010-08-29 22:29:40 UTC

Fix confirmed. 

The change works in 4.5.0, I will patch 4.5.1 manually and I am glad that this will be in 4.5.2. 

Thanks for the good work as usual, Martin. 

Kind regards

Fuchs

Comment 8 Piotr Budny 2010-09-01 17:53:42 UTC

*** Bug 249659 has been marked as a duplicate of this bug. ***

Comment 9 Thomas Lübking 2010-09-12 17:42:31 UTC

*** Bug 250988 has been marked as a duplicate of this bug. ***

Comment 10 Christoph Feck 2010-09-14 14:37:50 UTC

*** Bug 251213 has been marked as a duplicate of this bug. ***

Comment 11 Christoph Feck 2010-09-16 03:06:20 UTC

*** Bug 251399 has been marked as a duplicate of this bug. ***