Bug 240811

I have gathered some additional info: If I drag an album to the playlist from the “recently added albums” widget the moodbars of all the songs in the album are loaded correctly.

If I drag an album from the collection view directly to the playlist or if I just drag it onto the “add to playlist” button that appears in the widget area as soon as I start to drag the moodbars are NOT correctly loaded.

This works correctly for me. Could you try again with latest git.

Hi, the current Git does not compile for me. Perhaps that is due to me using the most decent KDE 4.5. I'll try again soon and post whether it works.

Current git compiles fine now, that was only a temporary glitch.

Hm, sorry. But it does not compile for me. I checked out a few minutes ago and get this error when compiling:


[ 15%] Building CXX object src/context/tools/CMakeFiles/amarokpkg.dir/amarokpkg.o            
Generating moc_PlaylistBreadcrumbItemSortButton.cpp                                          
Generating moc_Checkpoint.cpp                                                                
Generating moc_CompoundProgressBar.cpp                                                       
Generating moc_Bias.cpp                                                                      
Generating moc_ConstraintNode.cpp                                                            
Linking CXX executable amarokpkg                                                             
Generating moc_AmarokUrlAction.cpp                                                           
Generating moc_UnionJob.cpp                                                                  
Generating moc_BookmarkPopup.cpp                                                             
Generating moc_ServiceCollectionLocation.cpp                                                 
Generating moc_ServiceMetaBase.cpp                                                           
Generating moc_APGCategory.cpp                                                               
Generating moc_CollectionSetup.cpp                                                           
Generating moc_DefaultApplicationController.cpp                                              
Generating moc_FastForwardImporter.cpp                                                       
Generating moc_BiasSolver.cpp                                                                
Generating moc_DirectoryLoader.cpp                                                           
/usr/lib/libknewstuff3.so.4: undefined reference to `Attica::Provider::hasContentService() const'
collect2: ld gab 1 als Ende-Status zurück
make[2]: *** [src/context/tools/amarokpkg] Fehler 1
make[1]: *** [src/context/tools/CMakeFiles/amarokpkg.dir/all] Fehler 2
make[1]: *** Warte auf noch nicht beendete Prozesse...
Generating moc_RepeatAlbumNavigator.cpp
Generating moc_PlaylistBrowserCategory.cpp                                                   
Generating moc_ConstraintTestWrapper.cpp                                                     
Generating moc_PlaylistFileProvider.cpp                                                      
Generating moc_TagMatch.cpp                                                                  
Generating moc_PlaylistSortWidget.cpp                                                        
Generating moc_MediaDeviceMonitor.cpp                                                        
Generating moc_LayoutManager.cpp                                                             
Generating moc_TimecodeBoundedPlaybackCapability.cpp                                         
Generating moc_SearchProxy.cpp                                                               
Generating moc_Preset.cpp                                                                    
Generating moc_OcsPersonListWidget.cpp                                                       
Generating moc_LabelListModel.cpp                                                            
Generating moc_PresetModel.cpp                                                               
Generating moc_TreeController.cpp                                                            
Generating moc_PlaylistsByProviderProxy.cpp                                                  
Generating moc_DBusQueryHelper.cpp                                                           
Generating moc_DatabaseImporter.cpp                                                          
Generating moc_PlaylistBreadcrumbItem.cpp                                                    
Generating moc_AnimatedBarWidget.cpp                                                         
Generating moc_PlaylistActions.cpp                                                           
Generating moc_DynamicModel.cpp                                                              
Generating moc_TrackOrganizer.cpp                                                            
Generating moc_Token.cpp                                                                     
Generating moc_RepeatTrackNavigator.cpp                                                      
Generating moc_ConstraintGroup.cpp                                                           
Generating moc_GroupingProxy.cpp                                                             
Generating moc_PlaylistModelStack.cpp                                                        
Generating moc_ConstraintSolver.cpp                                                          
Generating moc_OneWaySynchronizationJob.cpp                                                  
Generating moc_TrackSelectWidget.cpp                                                         
Generating moc_TrackNavigator.cpp                                                            
Generating moc_TimecodeLoadCapability.cpp                                                    
Generating moc_SynchronizationBaseJob.cpp                                                    
Generating moc_MasterSlaveSynchronizationJob.cpp                                             
Generating moc_OcsPersonItem.cpp                                                             
Generating moc_QtGroupingProxy.cpp                                                           
Generating moc_RandomAlbumNavigator.cpp                                                      
Generating moc_MimeTypeFilterProxyModel.cpp                                                  
[ 15%] Built target amaroklib_automoc                                                        
make: *** [all] Fehler 2
    Breche ab ...


Is there something I can do to fix this?

Are you sure you have all dependencies and set the environment variables right? It very much looks like you haven't, still compiles flawlessly here, using 2.3.1-git on KDE 4.5, Qt 4.7.0 on Kubuntu 10.04

Could you please run make -j1 and paste the relevant error line? The above doesn't really show where the failure happens

Ok, I finally got around to looking into this bug some more. I compiled today’s git version of amarok and tried to reproduce this bug with it. Here is what I found out:

If I turn on the “merged view” of the local collection this bug is still present even in the current git. If however I turn off “merged view” everything works as expected (i.e. if you drag an album from the collection browser to the playlist every song has it’s own moodbar displayed).

In conclusion this bug only exists for the “merged view” of the collection browser.

Nikhil, could you test in "merged view" please? I don't have any moodbar for the files here right now.

I can reproduce this. more importantly it doesn't matter whether my tracks come from Merged/Unmerged view. The moodbar loading fault happens in either case, but *not to all tracks*. 

The first and last track in an album show the right moodbar, but the other tracks seem to cache the moodbar. Here is what I have observed

1) Play first track = Ok
2) First -> Last track   = Ok
3) Last  -> First track  = Ok
4) First/Last -> any track = Ok
5) Not first/last -> not/first last = Fail (moodbar does not change)

You seem to have checked this with the moodbar displayed in the progress bar. I on the other hand adjusted my playlist layout to display the moodbar for every song in it (as I liked it very much from amarok 1). In the playlist all tracks have the same moodbar when dragged there from the merged view. But I noticed the thing you described, too.

Edgar, yes I was viewing the toolbar, now I enabled moodbar in the playlist and I can clearly reproduce your bug. My variant of the bug seems to have disappeared or atleast is not on the songs I'm trying now. Will look into this.

This is an automated message from the triager:

Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug?

Without feedback within a month we will close this bug as resolved.

Thank you for your understanding.

I didn't try the "step to reproduce" described above, but you must move your mouse over the track progress slider in order to see the new moodbar.

Thank you for the fast feedback. I just tested myself with latest Amarok 2.4-git and that seems to be definitely solved, all tracks show individual moodbars in the playlist without having to hover over with the mouse.

Should I create another bug report if I need to hover the slider?

Do you use the git version? If not, it's not necessary to create a new bug, since I can't reproduce either in the latest git version, so this is solved in the next Amarok 2.4.2

This is still not solved in current git.
On manual trackchange i have to hover the progressbar in order to see the new mood-file.

Ah, never mind. There is a separate bugrport for my description: #234827

Created attachment 86186 [details]
Amarok-2.8.0 screenshot with invalid and repeated moodbars in playlist

This(In reply to comment #20)
> Created attachment 86186 [details]
> Amarok-2.8.0 screenshot with invalid and repeated moodbars in playlist

This still happens with Amarok-2.8.0 when I drag anything (artist, album or track) from the collection browser in merged mode.  In non-merged mode, behavior is fine.