Bug 238736

Summary:	[PATCH] collection browser should filter ratings by values between 0 and 5
Product:	[Applications] amarok	Reporter:	Daniel Faust <hessijames>
Component:	Collection Browser	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED INTENTIONAL
Severity:	minor	Keywords:	usability
Priority:	NOR
Version First Reported In:	2.3.0.90
Target Milestone:	2.3.2
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	multiply user input by 2

Description Daniel Faust 2010-05-24 21:58:00 UTC

Version:           2.3.0.90 (using KDE 4.3.5) 
OS:                Linux

at the moment the user has to filter by values between 0 and 10 but this is not consistent with the 5 star system. this patch converts the float input from the user to the int value for internal handling.

Reproducible: Didn't try

Comment 1 Daniel Faust 2010-05-24 21:59:19 UTC

Created attachment 43856 [details]
multiply user input by 2

Comment 2 Myriam Schweingruber 2010-05-25 10:42:31 UTC

Sorry, but I don't think we will use that, half a star is one point, and you can rate by half a star, this has always been like that in all Amarok versions and is on purpose.

Comment 3 Sven Krohlas 2010-05-25 14:16:06 UTC

Daniel, fyi: this just started a discussion on our amarok-devel mailing list:
http://mail.kde.org/pipermail/amarok-devel/2010-May/007124.html

We need to keep consistency across the application. So at least this patch needs to change all places where users can input rating information (dynamic and automatic playlist, tag dialog, etc). If the team agrees to change it this way.