| Summary: | url passes rss, kget icons which looks ugly | ||
|---|---|---|---|
| Product: | [Unmaintained] rekonq | Reporter: | m.wege |
| Component: | general | Assignee: | Andrea Diamantini <adjam7> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | pano_90 |
| Priority: | NOR | ||
| Version: | latest git snapshot | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 237890 | ||
| Attachments: | screenshot showing the problem | ||
Confirmed. What we could do is let the text fade out, when it comes near the icons, similar like it is done in KMess' window, when the status message is "touching" the window border. Yes that it is a possibility. Additionally it would make sense to have this special area of icons which relate to the current page also have an own background colour which should be made in way that it still indicates that it still belongs to the urlbar. http://trac.kmess.org/browser/src/widgets/gradientelidelabel.cpp There's the code for the text fading "magic" :) Might be helpful uhm... pano, one better link (without studying all kmess code)? Thanks ;) commit 9e5e6d59b75a5188620fd5428af37f61bb812b0c Author: Andrea Diamantini <adjam7@gmail.com> Date: Thu Jun 3 12:34:06 2010 +0200 This easy solution should fix problems with long urls that pass right icons BUG:238695 diff --git a/src/urlbar/urlbar.cpp b/src/urlbar/urlbar.cpp index b46eccd..33515de 100644 --- a/src/urlbar/urlbar.cpp +++ b/src/urlbar/urlbar.cpp @@ -303,7 +303,12 @@ void UrlBar::loadFinished() connect(bt, SIGNAL(clicked(QPoint)), _tab->page(), SLOT(showSSLInfo(QPoint))); } - update(); + // we need to update urlbar after the right icon settings + // removing this code (where setStyleSheet automatically calls update) needs adding again + // an update call + kDebug() << "resetting stylesheet"; + int rightIconWidth = 25 * (_rightIconsList.count()); + setStyleSheet(QString("UrlBar { padding: 0 %2px 0 %1px;} ").arg(_icon->sizeHint().width()).arg(rightIconWidth)); } |
Created attachment 43849 [details] screenshot showing the problem Version: unspecified (using KDE 4.4.3) OS: Linux If the url is long it does not stop at the point where the icons for rss, kget are in the urlbar. The url flow underneath them. That looks really ugly. Would be great if this could be changed. Reproducible: Always OS: Linux (i686) release 2.6.32-22-generic-pae Compiler: cc